chore(updatecli):Track docker image digests for ubuntu 22_04 AMD64 and ubuntu 22_04 ARM64
#1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d ARM64 Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
dduportal
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Good work, the updatecli manifests are good. As per my local tests (with scmid commented:
* key "$.docker.ubuntu.'22.04'.amd64" already set to "sha256:3d1556a8a18cf5307b121e0a98e93f1ddf1f3f8e092f1fddfd941254785b95d7", from file "./images-versions.yaml"
# ...
* key "$.docker.ubuntu.'22.04'.arm64" already set to "sha256:7c75ab2b0567edbb9d4834a2c51e462ebd709740d1f2c40bcd23c56e974fe2a8", from file "./images-versions.yaml"
There is a bit more of work to do:
- Blocker: The HCL change need to be fixed (please try it locally before pushing code which builds for 1 h).
Signed-off-by: jayfranco999 <[email protected]>
|
Tested locally and successfully: |
dduportal
approved these changes
Nov 12, 2024
dduportal
approved these changes
Nov 13, 2024
jayfranco999
added a commit
to jayfranco999/packer-images
that referenced
this pull request
Nov 26, 2024
…and `ubuntu 22_04 ARM64` (jenkins-infra#1508) * chore(updatecli):Track docker image digests for ubuntu 22_04 AMD64 and ARM64 Signed-off-by: jayfranco999 <[email protected]> * fixup Signed-off-by: jayfranco999 <[email protected]> * fixup Signed-off-by: jayfranco999 <[email protected]> --------- Signed-off-by: jayfranco999 <[email protected]> Co-authored-by: Damien Duportal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per jenkins-infra/helpdesk#4365 (comment)
This PR pins and track docker image digests for
ubuntu 22_04 AMD64andubuntu 22_04 ARM64