Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make install not exiting when fail #337

Open
smerle33 opened this issue Sep 14, 2022 · 2 comments
Open

make install not exiting when fail #337

smerle33 opened this issue Sep 14, 2022 · 2 comments
Labels
bug Something isn't working windows

Comments

@smerle33
Copy link
Contributor

as per https://infra.ci.jenkins.io/blue/organizations/jenkins/infra-tools%2Fpacker-images/detail/0.41.1/1/pipeline/249#step-306-log-261 the installation of make is not aborting the build when it fail.
@smerle33
Copy link
Contributor Author

this as for consequence to generate an error in the deleting process on azure-arm and windows VM probably due to a delay in stopping the machine.

@dduportal dduportal mentioned this issue Jan 9, 2023
Merged
@dduportal
Copy link
Contributor

As per #459 (comment) and https://ss64.com/ps/call.html, the ampersand (&) character runs the provided instruction as a background job, so the exit code is not captured.

Worth a PR to run the sanity check on a subsequent powershell provider AFTER running the windows-provision.ps1 provider.

@lemeurherve lemeurherve changed the title (windows): make install not exiting when fail make install not exiting when fail Jun 17, 2024
@lemeurherve lemeurherve added bug Something isn't working windows labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dduportal @lemeurherve @smerle33