Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown position in hamburger menu #208

Open
etorres07 opened this issue Oct 15, 2024 · 19 comments · May be fixed by jenkins-infra/jenkins-io-components#150
Open

Dropdown position in hamburger menu #208

etorres07 opened this issue Oct 15, 2024 · 19 comments · May be fixed by jenkins-infra/jenkins-io-components#150
Labels
bug Something isn't working hacktoberfest Participate to hacktoberfest

Comments

@etorres07
Copy link
Contributor

Reproduction steps

  1. Visit https://contributors.jenkins.io/.
  2. Reduce screen size until top navigation bar is in hamburger menu mode.
  3. Click any item with a dropdown box arrow (e.g. Documentation, Community, Subprojects, etc.)

Expected Results

The dropdown menu should be located below the clicked option, akin to the full-screen, non-hamburger, menu behavior.

Actual Results

The dropdown menu is located on the left side of the screen, far from the clicked option.

Anything else?

Example:
image

@etorres07 etorres07 added the bug Something isn't working label Oct 15, 2024
@krisstern
Copy link
Member

Thanks for filing this issue @etorres07!

@Utkarsh-Agarwal-585
Copy link

hi @etorres07 can I start work on this? Please assign it to me

@krisstern
Copy link
Member

krisstern commented Oct 23, 2024

Hi @Utkarsh-Agarwal-585 Thanks for your interest in this issue! However, we do not assign issues, but you are welcome to work on this. Please report your progress here. If we do not hear back from you regarding your progress or receive a PR from you over the next 7 days, the issue will be released.

@krisstern krisstern added the hacktoberfest Participate to hacktoberfest label Oct 23, 2024
@saurabhraghuvanshii
Copy link

saurabhraghuvanshii commented Nov 15, 2024

@krisstern is this bug is available , i want to work on this

@krisstern
Copy link
Member

Hi @saurabhraghuvanshii I am not sure if this bug can be fixed on our end (i.e. via contributions to this repo) but you can try to ceate a patch for it.

@saurabhraghuvanshii
Copy link

saurabhraghuvanshii commented Nov 15, 2024

hi @krisstern I didn't understand what is mean by patch . and I check website it show same thing as dropdown position in hamburger menu open left side of not at middle as we click , so I can I work on this , And thanks for your time

@krisstern
Copy link
Member

krisstern commented Nov 15, 2024

Hi @saurabhraghuvanshii you should really look up the word on your own using a dictionary of your choice. But basically according to the Oxford Dictionary of English it can mean:

6 Computing a small piece of code inserted into a program to improve its functioning or to correct a fault: a program patch that fixes a bug.

@saurabhraghuvanshii
Copy link

@krisstern thanks sir .

@saurabhraghuvanshii
Copy link

@krisstern sorry to ask sir , but after two days of try I am not able to find the file where drop-down code or css code written , even I check main repo code where this same bug arise in Jenkins.io . I check every single file.

@krisstern
Copy link
Member

Hi @saurabhraghuvanshii, if you look carefully at

src='https://unpkg.com/@jenkinsci/jenkins-io-components?module'
you will see we actually have a dependency for the header on https://github.com/jenkins-infra/jenkins-io-components. So that may be a good place to start.

@saurabhraghuvanshii
Copy link

@krisstern thanks sir , I found that components .

@saurabhraghuvanshii
Copy link

@krisstern fixed this issue make PR jenkins-infra/jenkins-io-components#150
Check it fix any changes to be made , I will do .

@krisstern
Copy link
Member

krisstern commented Nov 20, 2024

Hi @saurabhraghuvanshii, could you please put a line like

Fixes https://github.com/jenkins-infra/contributor-spotlight/issues/208

in the description of the PR at jenkins-infra/jenkins-io-components#150?

@saurabhraghuvanshii
Copy link

@krisstern done.

@krisstern
Copy link
Member

@saurabhraghuvanshii I mean to use the exact syntax in the description so that GitHub will close this issue once that PR is closed in the description up top:

Screenshot 2024-11-21 at 12 20 01 AM

Once you have this properly done it will show up on the right-hand side of the PR:

Screenshot 2024-11-21 at 12 18 45 AM

And please just copy and paste and don't get creative with it: Fixes https://github.com/jenkins-infra/contributor-spotlight/issues/208.

Any deviation from this will not work. Thanks!

@saurabhraghuvanshii
Copy link

@krisstern check it sir

@krisstern
Copy link
Member

@saurabhraghuvanshii It works now! Let me see how I can get someone to review your PR shortly.

@saurabhraghuvanshii
Copy link

@krisstern ok sir .

@saurabhraghuvanshii
Copy link

Hi @krisstern is any update regrading Pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Participate to hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants