-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown position in hamburger menu #208
Dropdown position in hamburger menu #208
Comments
Thanks for filing this issue @etorres07! |
hi @etorres07 can I start work on this? Please assign it to me |
Hi @Utkarsh-Agarwal-585 Thanks for your interest in this issue! However, we do not assign issues, but you are welcome to work on this. Please report your progress here. If we do not hear back from you regarding your progress or receive a PR from you over the next 7 days, the issue will be released. |
@krisstern is this bug is available , i want to work on this |
Hi @saurabhraghuvanshii I am not sure if this bug can be fixed on our end (i.e. via contributions to this repo) but you can try to ceate a patch for it. |
hi @krisstern I didn't understand what is mean by patch . and I check website it show same thing as dropdown position in hamburger menu open left side of not at middle as we click , so I can I work on this , And thanks for your time |
Hi @saurabhraghuvanshii you should really look up the word on your own using a dictionary of your choice. But basically according to the Oxford Dictionary of English it can mean:
|
@krisstern thanks sir . |
@krisstern sorry to ask sir , but after two days of try I am not able to find the file where drop-down code or css code written , even I check main repo code where this same bug arise in Jenkins.io . I check every single file. |
Hi @saurabhraghuvanshii, if you look carefully at contributor-spotlight/gatsby-ssr.jsx Line 12 in 53d6845
|
@krisstern thanks sir , I found that components . |
@krisstern fixed this issue make PR jenkins-infra/jenkins-io-components#150 |
Hi @saurabhraghuvanshii, could you please put a line like
in the description of the PR at jenkins-infra/jenkins-io-components#150? |
@krisstern done. |
@saurabhraghuvanshii I mean to use the exact syntax in the description so that GitHub will close this issue once that PR is closed in the description up top: Once you have this properly done it will show up on the right-hand side of the PR: And please just copy and paste and don't get creative with it: Any deviation from this will not work. Thanks! |
@krisstern check it sir |
@saurabhraghuvanshii It works now! Let me see how I can get someone to review your PR shortly. |
@krisstern ok sir . |
Hi @krisstern is any update regrading Pr |
Reproduction steps
Expected Results
The dropdown menu should be located below the clicked option, akin to the full-screen, non-hamburger, menu behavior.
Actual Results
The dropdown menu is located on the left side of the screen, far from the clicked option.
Anything else?
Example:
The text was updated successfully, but these errors were encountered: