Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish pipeline-steps-doc-generator and backend-extension-indexer artifacts to some kind of storage #3087

Closed
timja opened this issue Aug 5, 2022 · 11 comments

Comments

@timja
Copy link
Member

timja commented Aug 5, 2022

Service(s)

infra.ci.jenkins.io

Summary

https://github.com/jenkins-infra/jenkins.io/blob/9addc32ac8d366e02a9ec49e07e81ab527547cf4/scripts/fetch-external-resources#L36
and
https://github.com/jenkins-infra/jenkins.io/blob/9addc32ac8d366e02a9ec49e07e81ab527547cf4/scripts/fetch-external-resources#L66

cause site publishing to be reliant on ci.jenkins.io being up.

Which makes ci.jenkins.io a critical path for publishing security advisories and for contributors developing local site builds.

We should decouple these by publishing to some kind of storage.
Either reports.jenkins.io or an Azure storage, these need to be published publicly somewhere that any contributors machine can download from

see also #3086 (comment)

Reproduction steps

No response

@dduportal
Copy link
Contributor

@timja @daniel-beck do you agree with the following proposal?

  1. Migrating the job from ci.jenkins.io to infra.ci.jenkins.io, with the github checks enabled (e.g. build log shown in GitHub publicly)
  2. Adding a deployment to reports.jenkins.io (like the other reports) with the pipeline method publishReports()
  3. Update the github.com/jenkins-infra/jenkins.io's shell script fetch-external-resources.sh to use reports.jenkins.io instead of ci.j
  4. Once validated, then remove the job from ci.jenkins.io

@timja
Copy link
Member Author

timja commented Sep 7, 2022

sounds good

@daniel-beck
Copy link

daniel-beck commented Sep 7, 2022

do you agree with the following proposal?

Yes, absolutely, this has been terrible for a long time. We didn't have reports.j.io when this was set up, so this was a pragmatic way to do this.

Which makes ci.jenkins.io a critical path for publishing security advisories

This has bitten us once or twice; rather than ignoring some bullshit error on startup we have to urgently figure out what was wrong. Every time I complain about the 8 minute startup time of ci.j.io, this dependency from jenkins.io builds is why 😉

@dduportal
Copy link
Contributor

next step will be to remove the 2 jobs from ci.jenkins.io.

@dduportal
Copy link
Contributor

Both pipeline marked as archived in ci.jenkins.io (removed from the "include list" trait of the GH org scanning named Infra).

@daniel-beck
Copy link

Both pipeline marked as archived in ci.jenkins.io

To clarify, there is no value in having a public CI there?

@timja
Copy link
Member Author

timja commented Nov 7, 2022

They definitely should have public CI

@dduportal
Copy link
Contributor

ack, reopening to enable again public CI then

@smerle33
Copy link
Contributor

smerle33 commented Nov 21, 2022

in the process of merging the pipeline files from ci and infra.ci (to provide a public output), I will try to take the process for : pipeline-steps-doc-generator and leave backend-extension-indexer to @dduportal

@dduportal
Copy link
Contributor

Just added back the 2 repositories to ci.jenkins.io in https://ci.jenkins.io/job/Infra/ (updated the GH organization scanning job). Scanning in progress, that should add build checks for jenkins-infra/backend-extension-indexer#46 and jenkins-infra/pipeline-steps-doc-generator#241

@dduportal
Copy link
Contributor

dduportal commented Nov 29, 2022

MarkEWaite added a commit to MarkEWaite/pipeline-steps-doc-generator that referenced this issue Sep 22, 2024
jenkins-infra/helpdesk#3087 fixed the issue
that the documentation site build process was unnecessarily dependent
on ci.jenkins.io.  The zip file is now downloaded from reports.jenkins.io.
MarkEWaite added a commit to jenkins-infra/pipeline-steps-doc-generator that referenced this issue Sep 22, 2024
jenkins-infra/helpdesk#3087 fixed the issue
that the documentation site build process was unnecessarily dependent
on ci.jenkins.io.  The zip file is now downloaded from reports.jenkins.io.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants