Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using px in darkly theme should be discouraged #83

Open
jondoe1337 opened this issue Jul 27, 2020 · 4 comments
Open

Using px in darkly theme should be discouraged #83

jondoe1337 opened this issue Jul 27, 2020 · 4 comments

Comments

@jondoe1337
Copy link

Size is set to 15px. But this collides for example if you use bulma-switch where the variable is used with rem, which leads to:

Incompatible units: 'rem' and 'px'.
@jenil
Copy link
Owner

jenil commented Jul 27, 2020

I think you might want to handle this with custom CSS since bulma-switch is anyways a plugin right?

@jondoe1337
Copy link
Author

This sounds more like a workaround to me. The thing is that the themes sometimes use rem and darkly px. And some do not even define any size.

@jenil
Copy link
Owner

jenil commented Jul 27, 2020

I'm not sure if I understand this correctly then, can you make a codepen or point me to something? Darkly just updates the base variables and a few overrides to achieve the look

@jondoe1337
Copy link
Author

Sure:
https://github.com/jenil/bulmaswatch/blob/gh-pages/darkly/_variables.scss#L28
Uses px. If the size is used somewhere else with a relative setting using rem the sass compiler will crash.

Of course bulma-switch is a plugin, but I'd say that rem is more commonly used in the template context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants