Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Discord Username #281

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix Discord Username #281

wants to merge 5 commits into from

Conversation

chiragkrishna
Copy link
Contributor

Fixes: #276

@crobibero crobibero added the breaking This PR introduces breaking changes label Sep 7, 2024
@chiragkrishna
Copy link
Contributor Author

it is working as expected. may i know what is broken?

@crobibero
Copy link
Member

It's a breaking change, meaning that everyone with a discord connection configured will need to reconfigure.

@chiragkrishna
Copy link
Contributor Author

no it doesn't change the default behaviour.

BotUsername - Username of discord bot
NotificationUsername - Current user name
Username - user name in Authentication Failure

@crobibero
Copy link
Member

It is breaking in the case of ItemAdded or any non-user based notification.

@chiragkrishna
Copy link
Contributor Author

I don't understand how this PR will break Item added??
I've triple checked it now.
Screenshot 2024-09-09 220016

@chiragkrishna
Copy link
Contributor Author

this PR: #248 basically achieves the same thing. or am I missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

Assignees
No one assigned
Labels
breaking This PR introduces breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication Failure Discord Notification Type overwrites the {{Username}} Variable
3 participants
@chiragkrishna @crobibero @Shadowghost