Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Season and Show ItemIDs in BaseItem events #261

Open
kristianvld opened this issue Jul 8, 2024 · 3 comments
Open

Include Season and Show ItemIDs in BaseItem events #261

kristianvld opened this issue Jul 8, 2024 · 3 comments

Comments

@kristianvld
Copy link

For shows, currently the BaseItem event only includes the ItemId for the episode itself. It would be nice to also have the ID for the season and show as well. For instance I would like to include the backdrop image for the show itself in notifications and not just the episode image, but without the ID for the show or season, I don't see a way of doing this currently. We already have the show name and season number, so it seems natural to include the show and season IDs as well.

@crobibero
Copy link
Member

@kristianvld
Copy link
Author

Oh, it seems you are right. I'll have to test that out then, in which case I suppose this issue should be changed from adding the IDs themselves to just updating to documentation/readme to list them as well as I at least only check that when looking to create templates and not the C# code itself.

@chiragkrishna
Copy link
Contributor

this PR #271 solves it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants