Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suffix in file name #181

Open
iljab opened this issue Jul 8, 2020 · 10 comments
Open

Suffix in file name #181

iljab opened this issue Jul 8, 2020 · 10 comments

Comments

@iljab
Copy link

iljab commented Jul 8, 2020

Hi, is it possible to add the suffix to the file name and not the extension?

Current naming (resized lg):
58757eba-c286-46f0-b3c5-3c27473d7c2c.jpeg**-lg**

Expected naming behavior:
58757eba-c286-46f0-b3c5-3c27473d7c2c**-lg**.jpeg

@jeffminsungkim
Copy link
Owner

Thanks for opening an issue.
Is there any particular reason why do you need such a behavior?

@iljab
Copy link
Author

iljab commented Jul 10, 2020

If for example a customer downloads an image with the .jpeg-lg ending, most of the tools won't recognize it as an image. The original file ending gets lost.

@rbutera
Copy link

rbutera commented Jul 10, 2020

If for example a customer downloads an image with the .jpeg-lg ending, most of the tools won't recognize it as an image. The original file ending gets lost.

+1

In my opinion, I think that the current implementation is useful for a "file extension suffix" but does not serve the purpose of a "file name" suffix.

@jeffminsungkim
Copy link
Owner

@iljab Fair enough. Would you like to create a PR for this? 😺
@rbutera Good point.

@iljab
Copy link
Author

iljab commented Jul 11, 2020

@jeffminsungkim I will try

@jeffminsungkim
Copy link
Owner

Feel free to tell me if you need any help 😃

@rubiin
Copy link

rubiin commented May 3, 2021

Hi, is it possible to add the suffix to the file name and not the extension?

Current naming (resized lg):
58757eba-c286-46f0-b3c5-3c27473d7c2c.jpeg**-lg**

Expected naming behavior:
58757eba-c286-46f0-b3c5-3c27473d7c2c**-lg**.jpeg

is this when using randomFIleName option?

@hddananjaya
Copy link

hddananjaya commented May 4, 2021

Hi, is it possible to add the suffix to the file name and not the extension?
Current naming (resized lg):
58757eba-c286-46f0-b3c5-3c27473d7c2c.jpeg**-lg**
Expected naming behavior:
58757eba-c286-46f0-b3c5-3c27473d7c2c**-lg**.jpeg

is this when using randomFIleName option?

It happens with and without rahdomFileName option.

@jnovak-SM2Dev
Copy link

Any update on this? The suffix should definitely be attached to the file name and not the extension as to not cause issues with anything that would read an image/image extension (such as js galleries, etc).

@jnovak-SM2Dev
Copy link

I added a pull request to fix this #515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants