production flag in Version 3.8.3 does not work for older npm versions

[gemafrzen]

Hello,

the added code in pull request "Use "--omit=dev" internally on newer npm version (#86)" is not correct and the version check is always false. Thus the production flag is not used.

I think the solution is to change the following function

function getNpmVersion() {
    var version = child_process_1.exec('npm --version');
    return version.stdout.toString();
}

into

function getNpmVersion() {
  var version = child_process_1.execSync('npm --version');
    return version.toString();
}

In addition please re-add the test for older versions.

Best regards,
Erik

[ericcornelissen]

the added code in pull request "Use "--omit=dev" internally on newer npm version (#86)" is not correct and the version check is always false. Thus the production flag is not used.

I think the solution is to change the following function

function getNpmVersion() {
    var version = child_process_1.exec('npm --version');
    return version.stdout.toString();
}

into

function getNpmVersion() {
  var version = child_process_1.execSync('npm --version');
    return version.toString();
}

That seems plausible (I can't test this right now unfortunately), do you want to create a PR for this change?

In addition please re-add the test for older versions.

Feel free to submit a PR to run on older version, if they pass it should be good to go anyway.

[jeemok]

Released in 3.9.0. Thank you @ericcornelissen for fixing this!