Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when used with latest rn, ViewPropTypes has be deprecated #206

Open
shrynshjn opened this issue Nov 2, 2022 · 1 comment
Open

Comments

@shrynshjn
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-slider/lib/Slider.js b/node_modules/react-native-slider/lib/Slider.js
index c640410..aae12fc 100644
--- a/node_modules/react-native-slider/lib/Slider.js
+++ b/node_modules/react-native-slider/lib/Slider.js
@@ -5,6 +5,7 @@ var _react=require("react");var _react2=_interopRequireDefault(_react);
 
 
 var _reactNative=require("react-native");
+var _reactNativePropTypes=require("deprecated-react-native-prop-types");
 
 
 
@@ -548,14 +549,6 @@ return false;}}]);return Slider;}(_react.PureComponent);Slider.propTypes={ /**
      * Callback called when the user finishes changing the value (e.g. when
      * the slider is released).
      */onSlidingComplete:_propTypes2.default.func, /**
-     * The style applied to the slider container.
-     */style:_reactNative.ViewPropTypes.style, /**
-     * The style applied to the track.
-     */trackStyle:_reactNative.ViewPropTypes.style, /**
-     * The style applied to the thumb.
-     */thumbStyle:_reactNative.ViewPropTypes.style, /**
-     * Sets an image for the thumb.
-     */thumbImage:_reactNative.Image.propTypes.source, /**
      * Set this to true to visually see the thumb touch rect in green.
      */debugTouchArea:_propTypes2.default.bool, /**
      * Set to true to animate values with default 'timing' animation type
diff --git a/node_modules/react-native-slider/src/Slider.js b/node_modules/react-native-slider/src/Slider.js
index 37deee5..45e6506 100644
--- a/node_modules/react-native-slider/src/Slider.js
+++ b/node_modules/react-native-slider/src/Slider.js
@@ -11,8 +11,8 @@ import {
   PanResponder,
   View,
   Easing,
-  ViewPropTypes
 } from "react-native";
+import { ViewPropTypes, ImagePropTypes } from "deprecated-react-native-prop-types";
 
 import PropTypes from 'prop-types';
 
@@ -146,7 +146,7 @@ export default class Slider extends PureComponent {
     /**
      * Sets an image for the thumb.
      */
-    thumbImage: Image.propTypes.source,
+    thumbImage: ImagePropTypes.source,
 
     /**
      * Set this to true to visually see the thumb touch rect in green.

This issue body was partially generated by patch-package.

@sayancitytech
Copy link

I have added import { ViewPropTypes } from 'deprecated-react-native-prop-types'; in Slider.js
then yarn patch-package react-native-slider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants