Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CountryPresenter must not fetch data #1

Open
sharukhmohammed opened this issue May 23, 2019 · 1 comment
Open

CountryPresenter must not fetch data #1

sharukhmohammed opened this issue May 23, 2019 · 1 comment
Labels

Comments

@sharukhmohammed
Copy link

CountryPresenter is currently responsible for fetching the data, which actually must be done by CountryModel. This violates the separation of concerns

@jeancsanchez
Copy link
Owner

jeancsanchez commented May 23, 2019

@sharukhmohammed I agree with you, however, it is not the case here. If you are taking into account the principles that follow DDD and/or Clean Architecture, this can be the truth. But this project is a simple example of how to start with MVP. The main idea of this repository is to show for beginners how to start using MVP and they should improve this code on their own projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants