Skip to content
This repository has been archived by the owner on Nov 28, 2020. It is now read-only.

Cannot retreive authentication result #19

Open
jean-airoldie opened this issue May 12, 2019 · 16 comments
Open

Cannot retreive authentication result #19

jean-airoldie opened this issue May 12, 2019 · 16 comments
Labels
footgun A footgun to remove from the API

Comments

@jean-airoldie
Copy link
Owner

jean-airoldie commented May 12, 2019

When a connection succeeds the socket is no longer in mute state and can queue outgoing messages via send. The problem is if the authentication failed the user will never know it: he has effectively no way of knowing if his credentials were misconfigured. Here is the issue I filled zeromq/libzmq#3505.

@jean-airoldie jean-airoldie added the bug Something isn't working label May 12, 2019
@jean-airoldie jean-airoldie added footgun A footgun to remove from the API and removed bug Something isn't working labels May 12, 2019
@jean-airoldie

This comment has been minimized.

@jean-airoldie

This comment has been minimized.

@jean-airoldie

This comment has been minimized.

@jean-airoldie

This comment has been minimized.

@jean-airoldie jean-airoldie pinned this issue May 14, 2019
@jean-airoldie jean-airoldie added critical A critical issue and removed critical A critical issue labels May 14, 2019
@jean-airoldie jean-airoldie unpinned this issue May 14, 2019
@jean-airoldie
Copy link
Owner Author

Really unsure about what the best solution would be.

@jean-airoldie

This comment has been minimized.

@jean-airoldie

This comment has been minimized.

@jean-airoldie

This comment has been minimized.

@jean-airoldie jean-airoldie changed the title Send calls do not error when auth fails No way to know if auth failed May 15, 2019
@jean-airoldie

This comment has been minimized.

@jean-airoldie jean-airoldie changed the title No way to know if auth failed Cannot retreive authentication result May 15, 2019
@jean-airoldie
Copy link
Owner Author

My previous solution cannot work if you connect to an external socket. I think I will just create a monitoring socket per thread that will log authentication failures.

@jean-airoldie
Copy link
Owner Author

I created this PR that will allow use to use only one thread to log the monitor events from all sockets.

@jean-airoldie
Copy link
Owner Author

The PR was merged. I will create another issue for socket event monitoring.

This was referenced May 15, 2019
@jean-airoldie
Copy link
Owner Author

We can also detect handshake events via the new SocketMonitor API.

@jean-airoldie
Copy link
Owner Author

Some kind of wait_handshake helper function would be ideal.

@jean-airoldie jean-airoldie modified the milestone: 0.1 May 20, 2019
@jean-airoldie
Copy link
Owner Author

Conceptually a misconfiguration mechanism is indistinguishable from a missing endpoint. While it might be helpful from the application's perspective to detect misconfigure credentials, I can't really think of a good way to do so.

@jean-airoldie
Copy link
Owner Author

This can be fixed by #123

@jean-airoldie jean-airoldie reopened this Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
footgun A footgun to remove from the API
Projects
None yet
Development

No branches or pull requests

1 participant