Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpiler issues error 'This condition will always return 'false'' #18

Open
fcherny opened this issue Oct 20, 2020 · 0 comments
Open

Comments

@fcherny
Copy link

fcherny commented Oct 20, 2020

if (typeof dest === Array) {

When transpiling in typescript, the 'if' statement:
if (typeof dest === Array)
returns the error:
TS2367: This condition will always return 'false' since the types 'string' and 'ArrayConstructor' have no overlap.
I believe the statement should be changed to
if (dest instanceof Array)
as is done elsewhere in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant