Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Capability to use commits, PRs, tags, or branches to build from #154

Open
jes-so opened this issue Jul 30, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@jes-so
Copy link

jes-so commented Jul 30, 2024

The current structure of the building repositories takes only a branch argument. Other determinant arguments are valuable for various workflow situations, e.g. using the "last good SHA" in a branch build failure scenario.

I would like to contribute a non-breaking update where branch behavior is default, but optional arguments can override the default branch.

@jdoiro3
Copy link
Owner

jdoiro3 commented Aug 1, 2024

The import statement already supports pointing to a specific tag since branch is the same as the git clone --branch option (see here). Allowing any commit or a PR number would require some code changes.

@jes-so
Copy link
Author

jes-so commented Aug 1, 2024

You're right, I wrote my issue title clumsily! I meant that it would be good to have options between the four; I'll tweak the issue.

What kinds of changes in this vein would you welcome? I'd obviously like to avoid heavy restructures wherever possible and don't want to change the repo against your vision, but having a fallback SHA would be really valuable for my project. I was thinking about adding an optional commit arg, for example, which would be leveraged to checkout the SHA in sparse_clone.sh. (I included PR as well for this issue, primarily for the sake of completeness, but could break that out.) Would this be feasible?

@jes-so jes-so changed the title feature: Capability to use commits, PRs, or tags instead of branches to build from feature: Capability to use commits, PRs, tags, or branches to build from Aug 1, 2024
@jdoiro3 jdoiro3 added the enhancement New feature or request label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants