Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning Window element is broken #67

Open
AlaaSarhan opened this issue Dec 18, 2019 · 2 comments
Open

Cloning Window element is broken #67

AlaaSarhan opened this issue Dec 18, 2019 · 2 comments
Assignees

Comments

@AlaaSarhan
Copy link
Collaborator

AlaaSarhan commented Dec 18, 2019

Is

  • Cloning a window element just breaks everything .. like in this screenshot
    image
  • Assigned children inside the container are not cloned

Should

  • Cloning a window element should just create another proper window element as expected.. looking like the following
    image
  • Assigned children inside the container should be cloned too

Notes

  • selectedFigure.clone() does not seem to work just out-of-the-box when cloning a figure that have "real" children (that is Figure children in draw2d definition) such as the "Window" label that is inside a window figure
@AlaaSarhan AlaaSarhan self-assigned this Dec 18, 2019
@jdittrich
Copy link
Owner

another related question I had when testing this: should cloning a Container element also clone its "children"

Yes – this is what I would expect there and what typical graphics applications do, too.

@AlaaSarhan
Copy link
Collaborator Author

AlaaSarhan commented Dec 19, 2019

another related question I had when testing this: should cloning a Container element also clone its "children"

Yes – this is what I would expect there and what typical graphics applications do, too.

Updated description with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants