New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 code quality: Event initialization is messy, needs lots of files to be touched #63

Open

jdittrich opened this issue Dec 14, 2019 · 0 comments

Labels

question version2

Owner

jdittrich commented Dec 14, 2019

Not a high priority or severity but:

When changing how an element gets added to the canvas, I need to touch:

scr/app.js (binds jquery drop event to element creation)
lib/init.js (sets up sidebar and event callback for add-to-canvas )
src/sidebar/sidebarElements.js (creates sidebar elements, attaches the callback from init.js)

This makes code changes error prone.

jdittrich added question version2 labels

jdittrich mentioned this issue

v2: represent element as soon as drag enters canvas #64

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment