Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression effect change cannot be saved to workspace in isolation #295

Open
a-s-russo opened this issue May 23, 2024 · 8 comments
Open
Labels
bug Something isn't working

Comments

@a-s-russo
Copy link

When I change the 'Regression effect' for a user-defined variable (see first image below) and apply the change in the Specifications panel, I am not able to then save the workspace (see second image below).

image

image

A workaround for this issue is to simultaneously update some other parameter, apply both changes, save the workspace, and then undo the other parameter change, but clearly this is not the desired behaviour.

@charphi charphi added the bug Something isn't working label May 23, 2024
@palatej
Copy link
Contributor

palatej commented Jun 10, 2024

I was not able to reproduce the problem. Don't forget to save your changes to the saprocessing (through the apply/restore/save) buttons. That "save" doesn't save the workspace, but only put your new specifications in the current document.

@a-s-russo
Copy link
Author

a-s-russo commented Jun 10, 2024

Hi @palatej. Thanks for investigating this issue further.

I believe this issue I have reported is indeed a bug (unless the behaviour is intended), because I do not experience the problem with other parameters in either the Variables dialogue box or the Specifications panel. Furthermore, when I inspect the underlying XML file for the workspace, I can see the relevant tag has been updated for the regression effect parameter when I use the workaround I mention above. This suggests the workspace has indeed changed, hence it should be saveable when this parameter is changed.

For example, if I change the 'Lag' setting for a user-defined variable, click OK in the Variables dialogue box, then click Apply in the Specifications panel, the 'Save Workspace' in the File menu is clickable:

image

The same works for every other option in the Variables dialogue box, except for the 'Regression effect' option. If that option alone is changed and no others are changed, then even clicking on Ok and then Apply does not activate the 'Save Workspace' option.

@TanguyBarthelemy
Copy link

I can't reproduce the problem either.
When I change the Regression effect, press Apply and then Save, the Save Workspace button is no longer greyed out and is available and I can save my WS.

@a-s-russo
Copy link
Author

Thanks @TanguyBarthelemy for trying to replicate the bug. I have included a screen recording demonstrating the issue for me. In the first part of the recording, I show that changing other seasonal adjustment parameters can be successfully saved, and in the latter part of the recording, I show that this is not possible when changing the Regression effect. The recording can be extracted from this ZIP file: screen_recording.zip

@palatej
Copy link
Contributor

palatej commented Jul 10, 2024

Thanks a lot.
I see the problem now (it seems that it doesn't happen in multi-processing).

@TanguyBarthelemy
Copy link

Yes I thought too!

Yesterday I tested with Multi-Processing instead of a single document. I can confirm that I'm reproducing the problem now.

@a-s-russo
Copy link
Author

Thanks @palatej and @TanguyBarthelemy. I am glad to hear you can now reproduce the bug. I should have stated that I was using a single document rather than multi-processing document when first reporting this problem, but it is strange that it only impacts one and not the other! Looking forward to the bug fix.

@palatej
Copy link
Contributor

palatej commented Jul 10, 2024

Already done. An unfortunate small optimization...Will be in 3.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants