Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters list not refreshed when parameter changes affect other parameters #706

Open
ptorpey opened this issue Mar 6, 2022 · 1 comment · May be fixed by #707
Open

Parameters list not refreshed when parameter changes affect other parameters #706

ptorpey opened this issue Mar 6, 2022 · 1 comment · May be fixed by #707
Labels
p2 Medium priority. paramsDialog

Comments

@ptorpey
Copy link

ptorpey commented Mar 6, 2022

Don't know whether this is worth addressing or even possible to fix, but, as Scott says, maybe someone has a clever solution.

here is the scenario using ReaEq as an example:

  1. Add the ReaEQ plug-in to a track.
  2. In the parameters list change band 1 type to something like "notch". Note: The default is "Low Shelf".
  3. Arrow down to the Frequency for band 1. Osara announces "Frequency Low Shelf 1". In actuality, since the band 1 filter has changed, this should say "Frequency Notch 1".

Summary: When one parameter in the list is changed that affects another parameter in the list, the list is not accordingly updated to speak the proper info.

I don't know how many other plug-ins or parameters this might affect.

Fortunately the problem is easily rectified by closing the parameters list and re-opening it again. Then all parameters provide correct feedback.

In terms of a possible fix, it probably isn't a good idea to refresh the entire list each time a parameter is changed since one might be changing a parameter by hitting the up/down key quickly several times and we don't want to slow down this operation. An alternative might be to update the list if (a)a parameter has changed and (b)one has tabbed or shift+tabbed from the slider to the parameter list itself.

--Pete
@ScottChesworth ScottChesworth added p2 Medium priority. paramsDialog labels Mar 6, 2022
@ScottChesworth
Copy link
Collaborator

I've seen this impact intuitive usage with modular plug-ins, synths and suchlike. There are a handful of all-in-one guitar suites where this would also make a difference if fixable. The workflow in my case is picking a stomp to run ahead of an amp, then I have to reload the dialog before I can view named controls for the pedal I've made active.
As you say, not really a biggy, but it's worth having a think about.

jcsteh added a commit that referenced this issue Mar 7, 2022
@jcsteh
When the Parameter combo box in the Parameters dialog gets focus, reb…
33422f8 
…uild the parameter list.

This deals with cases where changing a parameter value also changes parameter names; e.g. changing the bad type in ReaEq.
Fixes #706.
@jcsteh jcsteh linked a pull request Mar 7, 2022 that will close this issue
Draft
jcsteh added a commit that referenced this issue May 7, 2022
@jcsteh
When the Parameter combo box in the Parameters dialog gets focus, reb…
d4dd873 
…uild the parameter list.

This deals with cases where changing a parameter value also changes parameter names; e.g. changing the bad type in ReaEq.
Fixes #706.
jcsteh added a commit that referenced this issue Aug 24, 2022
@jcsteh
When the Parameter combo box in the Parameters dialog gets focus, reb…
1aac1de 
…uild the parameter list.

This deals with cases where changing a parameter value also changes parameter names; e.g. changing the bad type in ReaEq.
Fixes #706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2 Medium priority. paramsDialog
Projects
None yet
Milestone
No milestone
2 participants
@ScottChesworth @ptorpey