We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 0afc1ef commit 9f26593Copy full SHA for 9f26593
src/Command.cpp
@@ -15,10 +15,12 @@ void Command::execute() {
15
16
char variableHeaderLength = 10; // TODO const
17
18
- // client id length needs to fix in the second byte of the connect
+ // client id length needs to fit in the second byte of the connect
19
// packet (remainingLength)
20
- if (mContext.clientId.size() > 255 - variableHeaderLength) {
21
- return; // TODO error handling
+ if (mContext.clientId.size() >
+ 255 - variableHeaderLength) { // TODO can this just be moved to
22
+ // earlier validation?
23
+ return; // TODO error handling
24
}
25
char remainingLength = variableHeaderLength + mContext.clientId.size();
26
0 commit comments