Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend extended ACK support to handle DUMP directives #262

Open
jbaublitz opened this issue Jan 24, 2025 · 1 comment · May be fixed by #267
Open

Extend extended ACK support to handle DUMP directives #262

jbaublitz opened this issue Jan 24, 2025 · 1 comment · May be fixed by #267
Assignees
Labels
Milestone

Comments

@jbaublitz
Copy link
Owner

Currently extended ACKs seem to only work for non-dump directives. This should be supported for dump too.

@jbaublitz
Copy link
Owner Author

From what I can tell looking at the kernel source code, there are two separate code paths for dump directives and request directives. In the case of dump directives, it appears the Nlmsghdr of the original message is never returned, just the error code and extended ACK attributes if requested. In the case of request directives, the regular rules seem to apply (entire message if the error code is non-zero, just the header if the error code is zero).

This poses a bit of a challenge in terms of how to handle the extended attributes at parse time. Unfortunately, it is not entirely clear from just the flags in the response whether to expect Nlmsghdr or not. Because this seems to be largely based on the request type, I'll have to evaluate how to generalize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant