From 6bca431a79821075791eafc203a62498efb3be27 Mon Sep 17 00:00:00 2001
From: Antoine LAURENT <antoine.c.laurent.pro@gmail.com>
Date: Mon, 18 Sep 2023 13:34:06 +0200
Subject: [PATCH] Improve coverage (#1317)

---
 tests/test_oidc_views.py | 37 +++++++++++++++++++++++++++++++++++--
 1 file changed, 35 insertions(+), 2 deletions(-)

diff --git a/tests/test_oidc_views.py b/tests/test_oidc_views.py
index 5ae354e56..201ff0436 100644
--- a/tests/test_oidc_views.py
+++ b/tests/test_oidc_views.py
@@ -6,7 +6,12 @@
 from django.utils import timezone
 from pytest_django.asserts import assertRedirects
 
-from oauth2_provider.exceptions import ClientIdMissmatch, InvalidOIDCClientError, InvalidOIDCRedirectURIError
+from oauth2_provider.exceptions import (
+    ClientIdMissmatch,
+    InvalidIDTokenError,
+    InvalidOIDCClientError,
+    InvalidOIDCRedirectURIError,
+)
 from oauth2_provider.models import get_access_token_model, get_id_token_model, get_refresh_token_model
 from oauth2_provider.oauth2_validators import OAuth2Validator
 from oauth2_provider.settings import oauth2_settings
@@ -236,6 +241,13 @@ def test_deprecated_validate_logout_request(
         client_id=client_id,
         post_logout_redirect_uri="http://example.org",
     ) == (ALWAYS_PROMPT, ("http://example.org", application), oidc_tokens.user)
+    with pytest.raises(InvalidIDTokenError):
+        validate_logout_request(
+            request=mock_request_for(oidc_tokens.user),
+            id_token_hint="111",
+            client_id=public_application.client_id,
+            post_logout_redirect_uri="http://other.org",
+        )
     with pytest.raises(ClientIdMissmatch):
         validate_logout_request(
             request=mock_request_for(oidc_tokens.user),
@@ -271,10 +283,18 @@ def test_deprecated_validate_logout_request(
             client_id=client_id,
             post_logout_redirect_uri="http://other.org",
         )
+    with pytest.raises(InvalidOIDCRedirectURIError):
+        rp_settings.OIDC_RP_INITIATED_LOGOUT_STRICT_REDIRECT_URIS = True
+        validate_logout_request(
+            request=mock_request_for(oidc_tokens.user),
+            id_token_hint=None,
+            client_id=public_application.client_id,
+            post_logout_redirect_uri="http://other.org",
+        )
 
 
 @pytest.mark.django_db
-def test_validate_logout_request(oidc_tokens, public_application):
+def test_validate_logout_request(oidc_tokens, public_application, rp_settings):
     oidc_tokens = oidc_tokens
     application = oidc_tokens.application
     client_id = application.client_id
@@ -306,6 +326,12 @@ def test_validate_logout_request(oidc_tokens, public_application):
         client_id=client_id,
         post_logout_redirect_uri="http://example.org",
     ) == (application, oidc_tokens.user)
+    with pytest.raises(InvalidIDTokenError):
+        view.validate_logout_request(
+            id_token_hint="111",
+            client_id=public_application.client_id,
+            post_logout_redirect_uri="http://other.org",
+        )
     with pytest.raises(ClientIdMissmatch):
         view.validate_logout_request(
             id_token_hint=id_token,
@@ -336,6 +362,13 @@ def test_validate_logout_request(oidc_tokens, public_application):
             client_id=client_id,
             post_logout_redirect_uri="http://other.org",
         )
+    with pytest.raises(InvalidOIDCRedirectURIError):
+        rp_settings.OIDC_RP_INITIATED_LOGOUT_STRICT_REDIRECT_URIS = True
+        view.validate_logout_request(
+            id_token_hint=None,
+            client_id=public_application.client_id,
+            post_logout_redirect_uri="http://other.org",
+        )
 
 
 @pytest.mark.django_db