Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version(s) to PyPi #311

Open
jwhitlock opened this issue Aug 12, 2020 · 4 comments
Open

Release new version(s) to PyPi #311

jwhitlock opened this issue Aug 12, 2020 · 4 comments

Comments

@jwhitlock
Copy link
Contributor

We're overdue for a release. My goal is to release basically what is in master, and then prepare for a second release with current Django support. I'll update this issue with what those look like.

@jwhitlock
Copy link
Contributor Author

v1.4.7 released to PyPI, supporting Django 2.2: https://pypi.org/project/django-nose/1.4.7

A v2.0 should:

  • Drop support for Django 1.8, 1.9, 1.10, 1.11, 2.0, 2.1
  • Add support for Django 3.0, 3.1, and master
  • Drop support for Python 2.6, 2.7, and 3.4
  • Add support for Python 3.8

This might allow removal of some compatibility code.

This gives users an upgrade path:

  • Upgrade to Python 3.5 or later, django-nose 1.4.7 and Django 2.2.
  • Upgrade to django-nose 2.0
  • Upgrade to Django 3.x and later Python versions

@ghassanmas
Copy link
Member

Hello @jwhitlock, thank you for the development of the project.

As I understand, you are not currently maintaing this project as stated in #310, that being said I am happy to contrbuite to it so it can support Django 3.2.

I would you really appercaite if you would give any guildine on how to move forward, for example would this #313, be a good start?

This library is being used by the OpenEdx platfomr, context here, so it's critcial for the team to make a decision in a timely manner on weather to keep using this library or look for alternatives.

Thank you again for your time

@jwhitlock
Copy link
Contributor Author

Hi @ghassanmas!

I don't have experience with nose2, so I don't know if #313 is possible. I suspect that a new code effort would be best for a Django wrapper. It looks like someone tried with https://github.com/jpellerin/django-nose2, but that appears abandoned.

My advice to continue with django-nose would be to prepare a v2.0 release like I described above, with changes for today's releases:

  • Drop support for Django 1.8, 1.9, 1.10, 1.11, 2.0, 2.1
  • Add support for Django 3.0, 3.1, 3.2 and master
  • Drop support for Python 2.6, 2.7, and 3.4
  • Add support for Python 3.8 and 3.9

If you have an active project using django-nose, then you are in a better position than I am to make and test these changes. I could review PRs and give feedback, and help with the transition to a maintainer.

@ghassanmas ghassanmas pinned this issue Sep 2, 2021
@jklemm
Copy link

jklemm commented Jul 4, 2022

Hi @jwhitlock and @ghassanmas!

I'm working in a big active project and using django-nose. We want to upgrade to Django 3.1+, but django-nose don't support it: typeerror: sql_flush() takes 3 positional arguments but 4 were given.

We want to help correct this issue, and upgrade django-nose to support new python and django versions.

It's just open issues, and send PRs to solve it? Can you guys help me a little?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants