From 652f61e83c3e860241d2e7a2127a81a5ead8e2b7 Mon Sep 17 00:00:00 2001 From: Dillon Lareau Date: Fri, 17 Jan 2020 10:52:31 -0500 Subject: [PATCH] Remove old unused "commit" option to loaddata.handle The "commit" option to loaddata hasn't been available since Django 1.5 and we can almost certainly rely on the existing handle function for it's database close logic. --- django_nose/runner.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/django_nose/runner.py b/django_nose/runner.py index d37b9dd..98db33e 100644 --- a/django_nose/runner.py +++ b/django_nose/runner.py @@ -320,7 +320,6 @@ def _foreign_key_ignoring_handle(self, *fixture_labels, **options): monkeypatched into place in setup_databases(). """ using = options.get('database', DEFAULT_DB_ALIAS) - commit = options.get('commit', True) connection = connections[using] # MySQL stinks at loading circular references: @@ -334,9 +333,6 @@ def _foreign_key_ignoring_handle(self, *fixture_labels, **options): cursor = connection.cursor() cursor.execute('SET foreign_key_checks = 1') - if commit: - connection.close() - def _skip_create_test_db(self, verbosity=1, autoclobber=False, serialize=True, keepdb=True):