Skip to content

Commit 1fe6f83

Browse files
authored
Merge pull request #321 from javierbrea/release
Release v4.0.1
2 parents e46a12c + e3e1f79 commit 1fe6f83

File tree

6 files changed

+16
-7
lines changed

6 files changed

+16
-7
lines changed

CHANGELOG.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
1111
### Removed
1212
### BREAKING CHANGES
1313

14+
## [4.0.1] - 2023-12-01
15+
16+
### Fixed
17+
- fix: Avoid error when rule element matchers define a capture key but some element does not have that capture key
18+
1419
## [4.0.0] - 2023-12-01
1520

1621
### Added
1722

18-
- feat(#213): Add `dependency-nodes` setting to allow analyzing dependencies from additional nodes, such as exports or dynamic imports.
19-
- feat: Add `additional-dependency-nodes` setting to add custom dependency nodes to the default ones. For example, you could enable to analyze dependencies in `jest.mock(...)`, etc.
23+
- feat(#213): Add `dependency-nodes` setting to allow analyzing dependencies from additional nodes, such as exports or dynamic imports. ([@gridsane](https://github.com/gridsane))
24+
- feat: Add `additional-dependency-nodes` setting to add custom dependency nodes to the default ones. For example, you could enable to analyze dependencies in `jest.mock(...)`, etc. ([@gridsane](https://github.com/gridsane))
2025

2126
### BREAKING CHANGES
2227

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "eslint-plugin-boundaries",
3-
"version": "4.0.0",
3+
"version": "4.0.1",
44
"description": "Eslint plugin checking architecture boundaries between elements",
55
"keywords": [
66
"eslint",

sonar-project.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
sonar.organization=javierbrea
22
sonar.projectKey=javierbrea_eslint-plugin-boundaries
3-
sonar.projectVersion=4.0.0
3+
sonar.projectVersion=4.0.1
44

55
sonar.javascript.file.suffixes=.js
66
sonar.sourceEncoding=UTF-8

src/helpers/rules.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function micromatchPatternReplacingObjectsValues(pattern, object) {
4545
function isObjectMatch(objectWithMatchers, object, objectsWithValuesToReplace) {
4646
return Object.keys(objectWithMatchers).reduce((isMatch, key) => {
4747
if (isMatch) {
48-
if (!object) {
48+
if (!object || !object[key]) {
4949
return false;
5050
}
5151
const micromatchPattern = micromatchPatternReplacingObjectsValues(

test/rules/one-level/element-types.spec.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,10 @@ testCapture(
749749
from: "modules",
750750
allow: [["h*", { elementName: "*-a" }], "c*", "m*"],
751751
},
752+
{
753+
from: "modules",
754+
disallow: [["h*", { foo: "*-a" }], "c*", "m*"],
755+
},
752756
],
753757
},
754758
],

0 commit comments

Comments
 (0)