Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Methods are missing in String Class #313

Open
gaurangkudale opened this issue Jan 22, 2022 · 3 comments
Open

New Methods are missing in String Class #313

gaurangkudale opened this issue Jan 22, 2022 · 3 comments
Labels
api support API support

Comments

@gaurangkudale
Copy link
Contributor

Java 11 adds a few new methods to the String class: isBlank, lines, strip, stripLeading, stripTrailing, and repeat.
These methods are missing in this path jpf-core/src/classes/java/lang/String.java which is supported by java 11

@cyrille-artho
Copy link
Member

We tend to add methods to model classes when needed. Some of these functions are not so widely used. If someone provides a pull request that also has a unit test to cover the new method, we will of course gladly merge it.

@gaurangkudale
Copy link
Contributor Author

We tend to add methods to model classes when needed. Some of these functions are not so widely used. If someone provides a pull request that also has a unit test to cover the new method, we will of course gladly merge it.

for this, we first need to add the methods in the model class and then unit test is that right?

@cyrille-artho
Copy link
Member

You would normally add the unit test first, to see that the unit test fails (and thus achieves something). The newly added method at step 2 would then fix the unit test.
The pull request then includes both the new test and new method (or class). You can commit your code in between steps without making a pull request.

@quadhier quadhier added the api support API support label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api support API support
Projects
None yet
Development

No branches or pull requests

3 participants