Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Reapplying conditions remove them #297

Open
4 of 7 tasks
SondreElg opened this issue Aug 15, 2024 · 1 comment · May be fixed by #298
Open
4 of 7 tasks

🐞 Reapplying conditions remove them #297

SondreElg opened this issue Aug 15, 2024 · 1 comment · May be fixed by #298

Comments

@SondreElg
Copy link
Contributor

SondreElg commented Aug 15, 2024 •
edited
Loading

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

  • add Blinded to Goblin 1 from an effect
  • Goblin 1 and Goblin 2 are hit by Color Spray and will both be Blinded
  • Blinded is added to Goblin 2 and no changes are made to Goblin 1

Current behaviour

  • add Blinded to Goblin 1 from an effect
  • Goblin 1 and Goblin 2 are hit by Color Spray and will both be Blinded
  • Blinded is added to Goblin 2 as expected
  • X Blinded is removed from Goblin 1

Reproduction

  • Create an encounter with a monster
  • Add a condition to the monster
  • (condition is applied)
  • Add the same condition to the monster again
  • (condition is removed)

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.6.7 and 1.7.0

Plugin Version

13.0.12

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

The current behaviour is technically intended, as it's hardcoded into src/tracker/stores/tracker.ts with corresponding logging behaviour. It is, however, confusing and a vestige from before we could remove conditions by crossing them out in the tracker itself.

Changing the behaviour would require rewriting most of the code in tracker.ts dealing with statuses.
@SondreElg SondreElg changed the title Reapplying conditions remove them 🐞 Reapplying conditions remove them Aug 15, 2024
@SondreElg SondreElg linked a pull request Aug 15, 2024 that will close this issue
Open
10 tasks
@Trantion897
Copy link

I'd just like to mention I've been working on a change that has similar effects, but haven't made a PR yet. My change displays the status values (in Pathfinder some statuses have a numeric value) on the player view, which meant I needed to do basically the same change you've done to distinguish between changing a status value or removing the status. I'll take a look at this change to try to minimise the chance of a merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reapplying conditions no longer removes them SondreElg/obsidian-initiative-tracker
2 participants
@Trantion897 @SondreElg