Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tag rollers return empty results #232

Open
3 of 7 tasks
rstenner opened this issue Jul 17, 2023 · 1 comment
Open
3 of 7 tasks

[Bug]: Tag rollers return empty results #232

rstenner opened this issue Jul 17, 2023 · 1 comment
Assignees
Labels
Type: Bug A problem with existing functionality.

Comments

@rstenner
Copy link

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

Given a vault with #tags used in one document, dice: #tags\|link should always roll the same result.

Current behaviour

an error is thrown in the console when nothing is shown:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'file')
at v6.build (plugin:obsidian-dice-roller:500:616)
at v6.render (plugin:obsidian-dice-roller:472:4530)
at eval (plugin:obsidian-dice-roller:500:1413)
at e.tryTrigger (app.js:1:906862)
at e.trigger (app.js:1:906795)
at v6.getFiles (plugin:obsidian-dice-roller:500:190)

Reproduction

  1. Launch obsidian in sandbox mode
  2. install Dataview plugin
  3. install Dice Roller plugin
  4. create a new note and type dice: #tags\|link
  5. clicking the dice to reroll will randomly roll [[Task]] and nothing approximately 50/50.

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.3.5

Plugin Version

9.0.0 and 9.2.0

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

Array indexing off by 1?

@rstenner rstenner added the bug label Jul 17, 2023
@sigrunixia sigrunixia added pinned Type: Bug A problem with existing functionality. and removed pinned labels Aug 6, 2023
@kyriss42
Copy link

kyriss42 commented Jan 4, 2024

I can confirm this bug. It is still present in the current version 10.4.1

That's why I'm still using 8.16.0 in which the correct links are generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants