Merge pull request #220 from javaevolved/brunoborges-remove-python-java-detection

Replace Python Java detector with Java 8 executable JAR

Author: brunoborges

.github/workflows/release-agent-plugin.yml

@@ -35,6 +35,11 @@ jobs:
         with:
           fetch-depth: 0
 
+      - uses: actions/setup-java@v6
+        with:
+          distribution: zulu
+          java-version: '8.0.492+9'
+
       - name: Determine release version
         id: version
         env:
@@ -101,9 +106,27 @@ jobs:
       - name: Validate plugin
         working-directory: agent-plugins/modern-java-development
         run: |
-          python3 -m unittest \
-            skills/modern-java/scripts/test_detect_java_version.py \
-            skills/modern-java/scripts/test_reference_coverage.py
+          classes=$(mktemp -d)
+          trap 'rm -rf "$classes"' EXIT
+          mkdir "$classes/source" "$classes/shipped" "$classes/tests"
+          javac -source 8 -target 8 -Xlint:-options \
+            -d "$classes/source" \
+            skills/modern-java/scripts/DetectJavaVersion.java
+          (
+            cd "$classes/shipped"
+            jar xf "$GITHUB_WORKSPACE/agent-plugins/modern-java-development/skills/modern-java/scripts/detect-java-version.jar"
+          )
+          rm -rf "$classes/shipped/META-INF"
+          diff --recursive "$classes/source" "$classes/shipped"
+          javac -source 8 -target 8 -Xlint:-options \
+            -cp skills/modern-java/scripts/detect-java-version.jar \
+            -d "$classes/tests" \
+            skills/modern-java/scripts/PluginValidationTest.java
+          java -cp "$classes/tests:skills/modern-java/scripts/detect-java-version.jar" \
+            PluginValidationTest ../..
+          javap -verbose \
+            -classpath skills/modern-java/scripts/detect-java-version.jar \
+            DetectJavaVersion | grep --quiet 'major version: 52'
           jq --exit-status \
             --arg version "${{ steps.version.outputs.version }}" \
             '.version == $version' plugin.json >/dev/null

agent-plugins/modern-java-development/README.md

@@ -21,9 +21,11 @@ modern-java-development/
         │   ├── enterprise-practices.md
         │   └── release-practices.md
         └── scripts/
-            ├── detect_java_version.py
-            ├── test_reference_coverage.py
-            └── test_detect_java_version.py
+            ├── DetectJavaVersion.java
+            ├── PluginValidationTest.java
+            ├── detect-java-version.cmd
+            ├── detect-java-version.jar
+            └── detect-java-version.sh
 ```
 
 ## Install
@@ -91,14 +93,22 @@ Agent Plugins manifest.
 
 When the skill is active, the agent runs the detector from the Java project root:
 
-```bash
-python3 skills/modern-java/scripts/detect_java_version.py .
+```console
+# macOS and Linux
+skills/modern-java/scripts/detect-java-version.sh .
+
+# Windows
+skills\modern-java\scripts\detect-java-version.cmd .
 ```
 
 Pass an explicit target when build metadata is unavailable:
 
-```bash
-python3 skills/modern-java/scripts/detect_java_version.py . --java-version 21
+```console
+# macOS and Linux
+skills/modern-java/scripts/detect-java-version.sh . --java-version 21
+
+# Windows
+skills\modern-java\scripts\detect-java-version.cmd . --java-version 21
 ```
 
 The detector emits JSON so an agent can distinguish the selected target from
@@ -107,9 +117,24 @@ lower-confidence runtime evidence and report conflicting build configuration.
 ## Validate
 
 ```bash
-python3 -m unittest \
-  skills/modern-java/scripts/test_detect_java_version.py \
-  skills/modern-java/scripts/test_reference_coverage.py
+set -e
+classes=$(mktemp -d)
+trap 'rm -rf "$classes"' EXIT
+jarfile="$PWD/skills/modern-java/scripts/detect-java-version.jar"
+mkdir "$classes/source" "$classes/shipped" "$classes/tests"
+javac -source 8 -target 8 -Xlint:-options \
+  -d "$classes/source" skills/modern-java/scripts/DetectJavaVersion.java
+(
+  cd "$classes/shipped"
+  jar xf "$jarfile"
+)
+rm -rf "$classes/shipped/META-INF"
+diff -r "$classes/source" "$classes/shipped"
+javac -source 8 -target 8 -Xlint:-options \
+  -cp "$jarfile" \
+  -d "$classes/tests" skills/modern-java/scripts/PluginValidationTest.java
+java -cp "$classes/tests:$jarfile" \
+  PluginValidationTest ../..
 ```
 
 ## Release

agent-plugins/modern-java-development/skills/modern-java/SKILL.md

@@ -2,7 +2,7 @@
 name: modern-java
 description: Detects a project's effective Java version and provides release-appropriate guidance for writing, reviewing, refactoring, upgrading, and modernizing Java code. Use for Java implementation, architecture, code review, build configuration, migration, performance, concurrency, testing, or API design tasks.
 license: MIT
-compatibility: Requires Python 3 to run the bundled detector; an agent may inspect the same project files directly when Python is unavailable.
+compatibility: Requires a Java 8 or newer runtime to run the bundled detector.
 metadata:
   author: "@brunoborges"
   version: "1.0.0"
@@ -18,8 +18,16 @@ features or APIs the build accepts.
 
 1. From the project or module root, run:
 
+   On macOS or Linux:
+
    ```bash
-   python3 <skill-directory>/scripts/detect_java_version.py .
+   <skill-directory>/scripts/detect-java-version.sh .
+   ```
+
+   On Windows:
+
+   ```bat
+   <skill-directory>\scripts\detect-java-version.cmd .
    ```
 
    If the user explicitly supplied Java version X, pass

agent-plugins/modern-java-development/skills/modern-java/references/core-practices.md

@@ -49,8 +49,12 @@ syntax available at the detected compilation target.
   cancellation, timeout, interruption, and failure propagation behavior.
 - Preserve interruption (`Thread.currentThread().interrupt()`) when an
   `InterruptedException` cannot be propagated.
+- Replace unsafe forced thread termination with cooperative cancellation and
+  explicit lifecycle ownership.
+  <!-- covers: thread-stop-to-cooperative-cancellation -->
 - Use concurrent collections and high-level synchronization utilities before
   hand-written locking. Document invariants protected by locks.
+  <!-- covers: wait-notify-to-blocking-queue -->
 - Measure before selecting executors, pool sizes, lock-free structures, or
   virtual-thread migration. CPU-bound and I/O-bound workloads need different
   strategies.

agent-plugins/modern-java-development/skills/modern-java/references/enterprise-practices.md

@@ -88,7 +88,7 @@ configuration before recommending a migration.
   explicit `@Configuration` over large XML bean graphs in modern Spring.
   Preserve XML where externalized wiring or legacy integration makes it useful;
   do not rely on broad component scanning that obscures ownership.
-  <!-- covers: spring-xml-config-vs-annotations -->
+  <!-- covers: spring-xml-config-vs-annotations spring-boot-mvc-config -->
 - On Spring Framework 7, use native API version conditions when they match the
   public versioning strategy. Keep version negotiation centralized, document
   deprecation and compatibility policy, and avoid merging unrelated versions

agent-plugins/modern-java-development/skills/modern-java/references/release-practices.md

@@ -7,6 +7,12 @@ on the exact runtime and module graph.
 
 ## Java 7 and older maintenance targets
 
+- Use generics instead of raw collections, `Deque` instead of legacy `Stack`,
+  and unsynchronized collections unless synchronization is part of the contract.
+  <!-- covers: raw-collections-to-generics stack-to-deque legacy-synchronized-collections -->
+- Use `ProcessBuilder` instead of `Runtime.exec`, construct URLs through `URI`,
+  and specify charsets explicitly at text/byte boundaries.
+  <!-- covers: runtime-exec-to-process-builder url-constructors-to-uri explicit-charset-file-io -->
 - Use multi-catch when handlers have identical behavior and neither alternative
   needs a more specific type. Preserve separate catches when recovery differs.
   <!-- covers: multi-catch -->
@@ -19,7 +25,11 @@ on the exact runtime and module graph.
 - Use lambdas and method references when they clarify behavior, and streams for
   side-effect-free transformations and reductions. Use
   `stream.toArray(Type[]::new)` when a typed array is the required API boundary.
-  <!-- covers: stream-toarray-typed -->
+  <!-- covers: anonymous-classes-to-lambdas stream-toarray-typed -->
+- Prefer collection bulk operations, `Map.compute`/`merge`, comparator factories,
+  and the standard Base64 codecs over hand-written equivalents when their
+  contracts match the required behavior.
+  <!-- covers: collection-bulk-operations map-compute-and-merge comparator-factories standard-base64 -->
 - Use `java.time`, `DateTimeFormatter`, `Duration`, and `Period` instead of
   mutable `Date`, `Calendar`, `SimpleDateFormat`, or unitless millisecond math.
   <!-- covers: java-time-basics date-formatting duration-and-period -->
@@ -51,7 +61,11 @@ on the exact runtime and module graph.
   <!-- covers: inputstream-transferto try-with-resources-effectively-final -->
 - Use `ProcessBuilder` to start processes and `ProcessHandle` to inspect or
   manage them. Drain output, bound waits, and handle process-tree termination.
-  <!-- covers: process-api -->
+  <!-- covers: process-api runtime-exec-to-process-builder -->
+- Use `StackWalker` for controlled stack inspection, `Cleaner` or explicit
+  resource ownership instead of finalization, and
+  `getDeclaredConstructor().newInstance()` instead of `Class.newInstance()`.
+  <!-- covers: stack-walker finalizers-to-resource-cleanup class-newinstance-to-constructor -->
 - Preserve nanosecond `Instant` precision through storage and serialization;
   do not silently truncate to epoch milliseconds.
   <!-- covers: instant-precision -->
@@ -89,7 +103,7 @@ on the exact runtime and module graph.
 - Prefer `java.net.http.HttpClient` for JDK-native HTTP. Reuse clients, configure
   connect/request timeouts, handle interruption, and validate status and body
   limits.
-  <!-- covers: http-client -->
+  <!-- covers: http-client http-websocket-client -->
 - Use `String.isBlank`, `strip`, `lines`, and `repeat` instead of hand-written
   equivalents. `strip` is Unicode-aware; `lines` recognizes multiple line
   terminators and does not retain them.
@@ -177,6 +191,9 @@ on the exact runtime and module graph.
   <!-- covers: junit6-with-jspecify -->
 - Treat strong encapsulation of JDK internals as a migration requirement, not
   something to bypass permanently with `--add-opens`.
+- Plan migrations away from the deprecated Security Manager around explicit
+  process, container, module, and application security boundaries.
+  <!-- covers: security-manager-migration -->
 
 ## Java 18-20
 
@@ -189,6 +206,9 @@ on the exact runtime and module graph.
 - Use try-with-resources for locally owned `ExecutorService` lifetimes. Define
   cancellation, graceful shutdown, timeout, and forced-shutdown behavior.
   <!-- covers: executor-try-with-resources -->
+- Use `Locale.of` instead of deprecated locale constructors, while preserving
+  language, region, variant, and BCP 47 semantics.
+  <!-- covers: locale-of -->
 - Record patterns, pattern switch, and virtual threads are not final before Java
   21.
 
@@ -245,6 +265,10 @@ on the exact runtime and module graph.
 
 ## Java 24
 
+- Use the Class-File API for class-file parsing, generation, and transformation
+  when its typed model fits; preserve unknown attributes and verify emitted
+  bytecode when interoperability matters.
+  <!-- covers: class-file-api -->
 - Use stream gatherers for reusable stateful intermediate operations when
   standard operations cannot express the transformation clearly. Respect
   integrator state, short-circuiting, parallel-combiner, and finisher semantics.