fix: UUID V4 generation (#138)

pankaj-kumar34 · web-flow · commit 5d0f88f64c12 · 2023-05-10T16:35:26.000+01:00
diff --git a/uuid.go b/uuid.go
@@ -17,5 +17,5 @@ func (UUID) V4() (uuid string) {
 	io.ReadFull(rand.Reader, uiq[:])
 	uiq[6] = (uiq[6] & 0x0f) | 0x40           // Version 4
 	uiq[8] = (uiq[8]&(0xff>>2) | (0x02 << 6)) // Variant RFC4122
-	return fmt.Sprintf("%x%x%x%x%x", uiq[0:4], uiq[4:6], uiq[6:8], uiq[8:10], uiq[10:])
+	return fmt.Sprintf("%x-%x-%x-%x-%x", uiq[0:4], uiq[4:6], uiq[6:8], uiq[8:10], uiq[10:])
 }
diff --git a/uuid_test.go b/uuid_test.go
@@ -8,7 +8,7 @@ import (
 func TestUUIDv4(t *testing.T) {
 	f := New()
 	value := f.UUID().V4()
-	match, err := regexp.MatchString("^[a-fA-F0-9]{8}[a-fA-F0-9]{4}4[a-fA-F0-9]{3}[8|9|aA|bB][a-fA-F0-9]{3}[a-fA-F0-9]{12}$", value)
+	match, err := regexp.MatchString("^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-4[a-fA-F0-9]{3}-[8|9|aA|bB][a-fA-F0-9]{3}-[a-fA-F0-9]{12}$", value)
 	Expect(t, true, err == nil)
 	Expect(t, true, match)
 }

Original file line number	Diff line number	Diff line change
`@@ -17,5 +17,5 @@ func (UUID) V4() (uuid string) {`
`17`	`17`	`io.ReadFull(rand.Reader, uiq[:])`
`18`	`18`	`uiq[6] = (uiq[6] & 0x0f) \| 0x40 // Version 4`
`19`	`19`	`uiq[8] = (uiq[8]&(0xff>>2) \| (0x02 << 6)) // Variant RFC4122`
`20`		`- return fmt.Sprintf("%x%x%x%x%x", uiq[0:4], uiq[4:6], uiq[6:8], uiq[8:10], uiq[10:])`
	`20`	`+ return fmt.Sprintf("%x-%x-%x-%x-%x", uiq[0:4], uiq[4:6], uiq[6:8], uiq[8:10], uiq[10:])`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import (`
`8`	`8`	`func TestUUIDv4(t *testing.T) {`
`9`	`9`	`f := New()`
`10`	`10`	`value := f.UUID().V4()`
`11`		`- match, err := regexp.MatchString("^[a-fA-F0-9]{8}[a-fA-F0-9]{4}4[a-fA-F0-9]{3}[8\|9\|aA\|bB][a-fA-F0-9]{3}[a-fA-F0-9]{12}$", value)`
	`11`	`+ match, err := regexp.MatchString("^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-4[a-fA-F0-9]{3}-[8\|9\|aA\|bB][a-fA-F0-9]{3}-[a-fA-F0-9]{12}$", value)`
`12`	`12`	`Expect(t, true, err == nil)`
`13`	`13`	`Expect(t, true, match)`
`14`	`14`	`}`