Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the .js from files that use the .cjs extension. #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove the .js from files that use the .cjs extension. #41

wants to merge 1 commit into from

Conversation

mendesbarreto
Copy link

Description

fixes #40

@mendesbarreto mendesbarreto changed the title Remove .js from file extension cjs Remove the .js from files that use the .cjs extension. Mar 1, 2024
@jasonsturges
Copy link
Owner

Interesting. Wonder if the module type caused the change.

Don’t have a problem with this - let me reproduce and double check CDN usage. But I think this is go.

@jasonsturges
Copy link
Owner

@mendesbarreto Really appreciate your proactive handling of this.

This might ultimately be applied, but I think there's some issue in the package module specifiers.

I'll keep this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onildoaguiar onildoaguiar onildoaguiar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: NexJS build: problem ReferenceError: exports is not defined in ES module scope
3 participants
@mendesbarreto @jasonsturges @onildoaguiar