Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includeLocales: true stopped working in 3.8.0 #187

Closed
mydea opened this issue Jul 24, 2020 · 5 comments
Closed

includeLocales: true stopped working in 3.8.0 #187

mydea opened this issue Jul 24, 2020 · 5 comments

Comments

@mydea
Copy link

mydea commented Jul 24, 2020

After updating from 3.5.0 to 3.8.0, includeLocales: true stopped working with the error:

ENOENT: no such file or directory, open '/tmp/broccoli-7755BBEmsOOPNspH/out-297-broccoli_debug_debug_2_vendor_js/vendor/moment/moment-with-locales.js'

Removing the line makes the build work again, however then it does not include all locales. It works if I manually specify locales.

This happens in an addon's dummy app.

@jasonmit
Copy link
Owner

jasonmit commented Aug 4, 2020

@mydea if at all possible, I'd move away from using this addon. Since you're bundling all locales it doesn't seem like you need any of it's capabilities.

It doesn't add much value anymore now that bundling libs is effortless with ember-auto-import.

@mydea
Copy link
Author

mydea commented Aug 4, 2020

Yeah, in that case it didn't really matter, as I could specify the locales, and it's just for an addon's dummy app. However, it was rather unexpected and took me some time to find the cause of my sudden build failures :)

@rreckonerr
Copy link

Got this same error upgrading from 3.7.1

@mehulkar
Copy link

cc @jrjohnson. Issue is from #184. Just need to change the import path:

https://github.com/jasonmit/ember-cli-moment-shim/pull/184/files#r564138289

@jrjohnson
Copy link
Collaborator

Locales can now be bundled without this addenda following the instructions at ember-moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants