Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke curl with -f in nvs.sh #250

Open
rkrisztian opened this issue Jun 29, 2022 · 0 comments
Open

Invoke curl with -f in nvs.sh #250

rkrisztian opened this issue Jun 29, 2022 · 0 comments

Comments

@rkrisztian
Copy link

With arm64 as a new platform supported by Node v16, I've noticed that if I want to use NVS in a project that still requires Node v14, nvs use will behave weirdly:

$ nvs use
Downloading NVS from https://github.com/jasongin/nvs
Downloading bootstrap node from https://nodejs.org/dist/v14.15.5/node-v14.15.5-darwin-arm64.tar.xz
-#O=#    #       #

For an experienced curl user, the above output should be fairly recognizable that something went wrong. However, for the average user, and for diagnostic purposes, I think it should also tell more, like what kind of error occurred.

The curl flag -f added to nvs.sh will make curl more scripting compatible, i.e. solve two problems:

  • If there's an error, we will see why, like curl: (22) The requested URL returned error: 404.
  • No archive file will be created with the content of a HTML error page, which is invalid. (Probably not an issue given you also perform hash checks.)

(Windows scripts do not seem to be affected.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant