Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6-Digit Animation #14

Closed
Noelle88 opened this issue Dec 26, 2021 · 8 comments
Closed

6-Digit Animation #14

Noelle88 opened this issue Dec 26, 2021 · 8 comments

Comments

@Noelle88
Copy link

Hi!
I think it’s a bug in the 6-digit lib.

showAnimation supports only the 4 digits in the middle, i think?

Unfortunately, my changes in the .h / .cpp from 4 to 6 did not work :-(

@jasonacox
Copy link
Owner

Hi @Noelle88 you are correct, the showAnimation() currently only supports 4-digits. It is on my "to-do" list to expand it to support 6-digits. Thanks for the feedback. It helps me add priority/motivation to make the updates. :-)

Happy new year!

@Noelle88
Copy link
Author

Noelle88 commented Jan 1, 2022

Okay, thanks for your feedback.
Then I'll try other functions of your lib until the showAnimation() works with 6-digits. ;-)

I wish you a happy new year, too!

@jasonacox
Copy link
Owner

Update: I have added the support for 6-digit animation, starting with the animation tool: https://jasonacox.github.io/TM1637TinyDisplay/examples/7-segment-animator6.html

The new code is on github but I need to finish some testing before I release the updated library for Arduino to pick up. You can pull the current version from github in the meantime if you want to help test.

@Noelle88
Copy link
Author

Noelle88 commented Jan 3, 2022

Okay, i made the following observations during the update:

TM1637-6Digit-Test.ino = The order of the digits is incorrect with showAnimation (). -> 23451
All other functions will work in the right order.

I wrote my own test sketch: The decimal point should be from right to left and then a 8 from right to left.

The result: (in digit-positions from left to right)

loop 1:
Point: 4-1-5-undefined pause-3-undefined pause
8: 1-5-undefined pause-3-1

loop 2:
Point: 3-4-1-undefined pause-5-6
8: 3-4-1-5-6-3

loop3: different again.....

I hope I could help

@jasonacox
Copy link
Owner

Thank you! That is very helpful. The issue was a zero index error I made in TM1637TinyDisplay6.cpp. I've corrected it and pushed the change.

I also added a longer PROGMEM animation test for the 6-digit display. Not great, but least gives a better demo of the capability.

I'll run a few more tests and then release this fix as v1.4.3.

@Noelle88
Copy link
Author

Noelle88 commented Jan 4, 2022

YES! It works perfectly! Thank you for your great support! have a nice day!

@jasonacox
Copy link
Owner

Thanks for the help!

@jasonacox
Copy link
Owner

Closing this issue. Please re-open if there is anything else we need to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants