Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with error code on any script errors #20

Open
AdamNowotny opened this issue Nov 30, 2012 · 1 comment
Open

Exit with error code on any script errors #20

AdamNowotny opened this issue Nov 30, 2012 · 1 comment

Comments

@AdamNowotny
Copy link

At the moment the task fails only if Jasmine tests failed, but reports success if all tests passed but some JS errors were present. It would be great to have an option to fail the build on any script errors as well.
This should help with catching errors not yet covered by jasmine tests.

Example:

Running "jasmine" task
Testing jasmine specs via phantom
Error: Script error
http://requirejs.org/docs/errors.html#scripterror
Error: Script error
http://requirejs.org/docs/errors.html#scripterror
31 specs, 0 failures in 0.305s.

Done, without errors.

ERRORLEVEL=0
@jsoverson
Copy link
Contributor

Good idea, thanks. This probably won't get implemented in jasmine-runner, as that is being deprecated upon grunt 0.4.0, feel free to open up a new issue https://github.com/gruntjs/grunt-contrib-jasmine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants