Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcr.io releases are disappearing #121

Closed
RichieSams opened this issue Jan 7, 2025 · 3 comments · Fixed by #128
Closed

ghcr.io releases are disappearing #121

RichieSams opened this issue Jan 7, 2025 · 3 comments · Fixed by #128

Comments

@RichieSams
Copy link

Hi! Thanks for continuing mtail on.

A few months ago, I switched my usage from the old google mtail docker container to your ghcr.io repo. And everything was working well. Today, I was doing work on my repo, and I got a test failure, because it's failing to find the docker image in ghcr.io

ghcr.io/jaqx0r/mtail:3.0.16

Does ghcr.io have some kind of limit to the number / frequency of tags? If I look at your repo, there are only 14 tags: https://github.com/jaqx0r/mtail/pkgs/container/mtail/versions?filters%5Bversion_type%5D=tagged

Also, it looks like you're pushing a new tag every week on a cron job: https://github.com/jaqx0r/mtail/blob/main/.github/workflows/tag-new-release.yml

Can you explain why? If the code hasn't changed, why do we need a new tagged release?

Thanks!

-RichieSams

@RichieSams
Copy link
Author

@jaqx0r
Copy link
Owner

jaqx0r commented Feb 15, 2025

There's a release every week if there are new changes committed to the repo. There's no release when there hasn't been any changes.

The cleanup job is intended to avoid stale copies. I think it's too eager though, you're right. Perhaps I shold leave 50 copies around so that it's about a year ?

@jaqx0r
Copy link
Owner

jaqx0r commented Feb 15, 2025

Did you want to be able to pin the version? ghcr.io/jaqx0r/mtail:latest should always work especially in test.

jaqx0r added a commit that referenced this issue Feb 15, 2025
If we build once a week then this gives about a year of pinning before people
have to upgrade.  Personally I think 90 days should be the limit but I can't be
too prescriptive.

Fixes: #121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants