Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 support? #281

Open
ndom91 opened this issue Jan 16, 2024 · 1 comment
Open

Svelte 5 support? #281

ndom91 opened this issue Jan 16, 2024 · 1 comment
Labels
awaiting upstream Needs new release from an upstream dependency pkg Package

Comments

@ndom91
Copy link

ndom91 commented Jan 16, 2024

Repro

image

Additional context

Are there any plans for Svelte 5 updates yet? I know its early, but yeah figured I'd ask 😊

@ndom91 ndom91 added the bug Something isn't working label Jan 16, 2024
@janosh
Copy link
Owner

janosh commented Jan 16, 2024

@ndom91 Svelte v5 support is definitely coming!

I remember there was a reason for having ondrop="return false" over ondrop={() => false} but maybe that's no longer the case with Svelte 5. If so, easy fix.
The main blocker right now is mdsvexamples used extensively in the docs. Just upgraded to 5.0.0-next.35 and still get vite compilation errors:

    at option (/Users/janosh/dev/svelte-multiselect/src/site/Examples.svx___mdsvexample___2.svelte:37:49)
    at Module.slot (/Users/janosh/dev/svelte-multiselect/node_modules/.pnpm/svelte@5.0.0-next.35/node_modules/svelte/src/internal/server/index.js:440:3)
    at $$render_inner (/Users/janosh/dev/svelte-multiselect/src/lib/MultiSelect.svelte:762:27)
    at MultiSelect (/Users/janosh/dev/svelte-multiselect/src/lib/MultiSelect.svelte:885:3)
    at Examples_svx___mdsvexample___2 (/Users/janosh/dev/svelte-multiselect/src/site/Examples.svx___mdsvexample___2.svelte:26:35)
    at /Users/janosh/dev/svelte-multiselect/src/site/Examples.svx:189:48
    at Module.slot (/Users/janosh/dev/svelte-multiselect/node_modules/.pnpm/svelte@5.0.0-next.35/node_modules/svelte/src/internal/server/index.js:437:4)
    at example (/Users/janosh/dev/svelte-multiselect/src/site/Examples.svx:184:11)
    at Module.slot (/Users/janosh/dev/svelte-multiselect/node_modules/.pnpm/svelte@5.0.0-next.35/node_modules/svelte/src/internal/server/index.js:440:3)
    at CodeExample (/Users/janosh/dev/svelte-multiselect/node_modules/.pnpm/svelte-zoo@0.4.9_vite@5.0.11/node_modules/svelte-zoo/dist/CodeExample.svelte:70:25)
11:43:02 AM [vite] warning: Example src not found for /Users/janosh/dev/svelte-multiselect/___mdsvexample___0.svelte

Feel free to chime in at mattjennings/mdsvexamples#30 if you think now's the time to address these.

@janosh janosh added awaiting upstream Needs new release from an upstream dependency pkg Package and removed bug Something isn't working labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting upstream Needs new release from an upstream dependency pkg Package
Projects
None yet
Development

No branches or pull requests

2 participants