ESLINT - no-var (handsontable#5317)

* Changed: /test/unit/**/*.spec.js

* Changed: /test/helpers/*.js + Fix: unit test for PluginHooks

* Changed: /test/e2e/validators/*.js

* Changed: /test/e2e/utils/*.js

* Changed: /test/e2e/settings/*.js

* Changed: /test/e2e/renderers/*.js

* Changed: /test/e2e/editors/*.js

* Changed: /test/e2e/core/*.js

* Changed: /test/e2e/*.spec.js

* Changed: /src/plugins/**/test/*.js

* Changed: /src/3rdparty/walkontable/**/test/*.js

* Changed: rest of /src/**/*.js

* A few changes in tests and dom helper.

Author: swistach

.eslintrc

@@ -49,7 +49,6 @@
       }
     ],
     "no-use-before-define": 0,
-    "no-var": 0,
     "no-void": 0,
     "no-with": 2,
     "object-curly-spacing": 0,

src/3rdparty/walkontable/src/event.js

@@ -18,10 +18,10 @@ function Event(instance) {
 
   this.instance = instance;
 
-  var dblClickOrigin = [null, null];
+  const dblClickOrigin = [null, null];
   this.dblClickTimeout = [null, null];
 
-  var onMouseDown = function(event) {
+  const onMouseDown = function(event) {
     const activeElement = document.activeElement;
     const getParentNode = partial(getParent, event.realTarget);
     const realTarget = event.realTarget;
@@ -33,7 +33,7 @@ function Event(instance) {
       return;
     }
 
-    var cell = that.parentCell(realTarget);
+    const cell = that.parentCell(realTarget);
 
     if (hasClass(realTarget, 'corner')) {
       that.instance.getSetting('onCellCornerMouseDown', event, realTarget);
@@ -64,11 +64,11 @@ function Event(instance) {
     }
   };
 
-  var onTouchMove = function() {
+  const onTouchMove = function() {
     that.instance.touchMoving = true;
   };
 
-  var onTouchStart = function(event) {
+  const onTouchStart = function(event) {
     eventManager.addEventListener(this, 'touchmove', onTouchMove);
 
     // Prevent cell selection when scrolling with touch event - not the best solution performance-wise
@@ -84,10 +84,10 @@ function Event(instance) {
     }, 30);
   };
 
-  var onMouseOver = function(event) {
-    var table,
-      td,
-      mainWOT;
+  const onMouseOver = function(event) {
+    let table;
+    let td;
+    let mainWOT;
 
     if (that.instance.hasSetting('onCellMouseOver')) {
       table = that.instance.wtTable.TABLE;
@@ -102,7 +102,7 @@ function Event(instance) {
     }
   };
 
-  var onMouseOut = function(event) {
+  const onMouseOut = function(event) {
     let table;
     let lastTD;
     let nextTD;
@@ -118,9 +118,9 @@ function Event(instance) {
     }
   };
 
-  var onMouseUp = function(event) {
+  const onMouseUp = function(event) {
     if (event.button !== 2) { // if not right mouse button
-      var cell = that.parentCell(event.realTarget);
+      const cell = that.parentCell(event.realTarget);
 
       if (cell.TD === dblClickOrigin[0] && cell.TD === dblClickOrigin[1]) {
         if (hasClass(event.realTarget, 'corner')) {
@@ -162,7 +162,7 @@ function Event(instance) {
     return false;
   };
 
-  var onTouchEnd = function(event) {
+  const onTouchEnd = function(event) {
     const excludeTags = ['A', 'BUTTON', 'INPUT'];
     const target = event.target;
 
@@ -182,7 +182,7 @@ function Event(instance) {
 
   // check if full HOT instance, or detached WOT AND run on mobile device
   if (this.instance.wtTable.holder.parentNode.parentNode && isMobileBrowser() && !that.instance.wtTable.isWorkingOnClone()) {
-    var classSelector = `.${this.instance.wtTable.holder.parentNode.className.split(' ').join('.')}`;
+    const classSelector = `.${this.instance.wtTable.holder.parentNode.className.split(' ').join('.')}`;
 
     eventManager.addEventListener(this.instance.wtTable.holder, 'touchstart', (event) => {
       selectedCellBeforeTouchEnd = instance.selections.getCell().cellRange;
@@ -235,9 +235,9 @@ function Event(instance) {
 }
 
 Event.prototype.parentCell = function(elem) {
-  var cell = {};
-  var TABLE = this.instance.wtTable.TABLE;
-  var TD = closestDown(elem, ['TD', 'TH'], TABLE);
+  const cell = {};
+  const TABLE = this.instance.wtTable.TABLE;
+  const TD = closestDown(elem, ['TD', 'TH'], TABLE);
 
   if (TD) {
     cell.coords = this.instance.wtTable.getCoords(TD);

src/3rdparty/walkontable/src/overlay/_base.js

@@ -238,7 +238,7 @@ class Overlay {
    */
   refresh(fastDraw = false) {
     // When hot settings are changed we allow to refresh overlay once before blocking
-    var nextCycleRenderFlag = this.shouldBeRendered();
+    const nextCycleRenderFlag = this.shouldBeRendered();
 
     if (this.clone && (this.needFullRender || nextCycleRenderFlag)) {
       this.clone.draw(fastDraw);

src/3rdparty/walkontable/test/helpers/common.js

@@ -19,13 +19,13 @@ export function createDataArray(rows, cols) {
   rows = typeof rows === 'number' ? rows : 100;
   cols = typeof cols === 'number' ? cols : 4;
 
-  for (var i = 0; i < rows; i++) {
-    var row = [];
+  for (let i = 0; i < rows; i++) {
+    const row = [];
 
     if (cols > 0) {
       row.push(i);
 
-      for (var j = 0; j < cols - 1; j++) {
+      for (let j = 0; j < cols - 1; j++) {
         /* eslint-disable no-mixed-operators */
         /* eslint-disable no-bitwise */
         row.push(String.fromCharCode(65 + j % 20).toLowerCase() + (j / 20 | 0 || '')); // | 0 is parseInt - see http://jsperf.com/math-floor-vs-math-round-vs-parseint/18
@@ -47,12 +47,12 @@ export function getTotalColumns() {
   return spec().data[0] ? spec().data[0].length : 0;
 };
 
-var currentSpec;
+let currentSpec;
 
 beforeEach(function() {
   currentSpec = this;
 
-  var matchers = {
+  const matchers = {
     toBeInArray() {
       return {
         compare(actual, expected) {
@@ -76,8 +76,8 @@ beforeEach(function() {
         compare(actual, expected, diff) {
           diff = diff || 1;
 
-          var pass = actual >= expected - diff && actual <= expected + diff;
-          var message = `Expected ${actual} to be around ${expected} (between ${expected - diff} and ${expected + diff})`;
+          const pass = actual >= expected - diff && actual <= expected + diff;
+          let message = `Expected ${actual} to be around ${expected} (between ${expected - diff} and ${expected + diff})`;
 
           if (!pass) {
             message = `Expected ${actual} NOT to be around ${expected} (between ${expected - diff} and ${expected + diff})`;
@@ -117,7 +117,7 @@ export function range(from, to) {
     from = [to, to = from][0]; // one-liner for swapping two values
   }
 
-  var result = [];
+  const result = [];
 
   while (to++ < from) {
     result.push(to);
@@ -194,12 +194,12 @@ export function getTableCornerClone() {
 }
 
 export function createSpreadsheetData(rows, columns) {
-  var _rows = [],
-    i,
-    j;
+  const _rows = [];
+  let i;
+  let j;
 
   for (i = 0; i < rows; i++) {
-    var row = [];
+    const row = [];
 
     for (j = 0; j < columns; j++) {
       row.push(spreadsheetColumnLabel(j) + (i + 1));
@@ -234,11 +234,11 @@ export function spreadsheetColumnLabel(index) {
 }
 
 export function walkontableCalculateScrollbarWidth() {
-  var inner = document.createElement('div');
+  const inner = document.createElement('div');
   inner.style.height = '200px';
   inner.style.width = '100%';
 
-  var outer = document.createElement('div');
+  const outer = document.createElement('div');
   outer.style.boxSizing = 'content-box';
   outer.style.height = '150px';
   outer.style.left = '0px';
@@ -250,9 +250,9 @@ export function walkontableCalculateScrollbarWidth() {
   outer.appendChild(inner);
 
   (document.body || document.documentElement).appendChild(outer);
-  var w1 = inner.offsetWidth;
+  const w1 = inner.offsetWidth;
   outer.style.overflow = 'scroll';
-  var w2 = inner.offsetWidth;
+  let w2 = inner.offsetWidth;
   if (w1 === w2) {
     w2 = outer.clientWidth;
   }
@@ -262,7 +262,7 @@ export function walkontableCalculateScrollbarWidth() {
   return (w1 - w2);
 }
 
-var cachedScrollbarWidth;
+let cachedScrollbarWidth;
 
 export function getScrollbarWidth() {
   if (cachedScrollbarWidth === void 0) {

src/3rdparty/walkontable/test/spec/border.spec.js

@@ -1,8 +1,8 @@
 describe('WalkontableBorder', () => {
-  var $table,
-    $container,
-    $wrapper,
-    debug = false;
+  let $table;
+  let $container;
+  let $wrapper;
+  let debug = false;
 
   beforeEach(() => {
     $container = $('<div></div>');