Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ClientToken from @y-sweet/react and @y-sweet/client #149

Closed
wants to merge 1 commit into from

Conversation

paulgb
Copy link
Member

@paulgb paulgb commented Sep 26, 2023

Closes #129.

  • Moves encodeClientToken, which is only used on the client, into @y-sweet/client.
  • Exports ClientToken from @y-sweet/react and @y-sweet/client, so that clients do not have to depend on @y-sweet/sdk just for type safety.

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
y-sweet-debugger ❌ Failed (Inspect) Sep 26, 2023 3:26pm
y-sweet-demos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 3:26pm
y-sweet-gendocs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 3:26pm

Copy link
Member

@rolyatmax rolyatmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is the plan to follow this with a version bump and publish?

@rolyatmax
Copy link
Member

Also looks like the debugger expects decodeClientToken from the sdk?

@paulgb paulgb closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider @y-sweet/react re-exporting ClientToken type
2 participants