Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings should be silenced in testing #4

Open
jamiemccarthy opened this issue Apr 26, 2022 · 1 comment
Open

Deprecation warnings should be silenced in testing #4

jamiemccarthy opened this issue Apr 26, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jamiemccarthy
Copy link
Owner

The test suite for ActiveRecord 5.x emits deprecation warnings. They don't break anything but they are ugly and may confuse people reading the test suite output into thinking there is something wrong. Since these warnings are expected, they should be silenced.

There are two:

  1. SQLite 1.3 warning of incompatibility with Ruby 3.2 (which is irrelevant since Rails 5 won't run on Ruby 3.2 and Rails 6 requires SQLite 1.4).
  2. DEPRECATION WARNING: Leaving ActiveRecord::ConnectionAdapters::SQLite3Adapter.represent_boolean_as_integer set to false is deprecated.
@jamiemccarthy jamiemccarthy added the enhancement New feature or request label Apr 26, 2022
@jamiemccarthy
Copy link
Owner Author

Technically there's a third, but it's similar to the first:

/usr/local/bundle/gems/activerecord-5.2.8.1/lib/active_record/connection_adapters/sqlite3_adapter.rb:32: warning: rb_check_safe_obj will be removed in Ruby 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant