Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onDotClicked() doesn't work when the canvas has padding #33

Open
brazzy opened this issue Dec 7, 2020 · 0 comments
Open

onDotClicked() doesn't work when the canvas has padding #33

brazzy opened this issue Dec 7, 2020 · 0 comments

Comments

@brazzy
Copy link

brazzy commented Dec 7, 2020

For my game's layout I wanted to give its canvas some padding via CSS, but that caused the coordinate calculation in CanvasIOManager.prototype._listenForMouseClick to fail. I guess the result of getBoundingClientRect() includes the padding. Hopefully there is an easy fix.

While we're at it: there must be a more efficient way to find the correct dot than to iterate over all of them.

I'd be willing to fix this myself, if pull requests are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant