Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where dependencies are missing #7

Open
jamesmcm opened this issue Jul 19, 2020 · 3 comments
Open

Handle cases where dependencies are missing #7

jamesmcm opened this issue Jul 19, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@jamesmcm
Copy link
Owner

If wireguard-tools or openvpn are missing then warn the user and handle error from std::Process.

Make them mandatory in AUR packages, and add dependencies to README for other distros (Debian, Fedora, etc.)

@jamesmcm jamesmcm added the good first issue Good for newcomers label Jul 19, 2020
@jamesmcm
Copy link
Owner Author

jamesmcm commented Aug 9, 2020

Done in #13

@jamesmcm jamesmcm closed this as completed Aug 9, 2020
@joelpet
Copy link

joelpet commented Dec 20, 2020

Make them mandatory in AUR packages, and add dependencies to README for other distros (Debian, Fedora, etc.)

This part does not seem to be done. Here's what the currently most recent Debian package looks like on my machine (notice the lack of Depends: wireguard-tools):

Package: vopono
Version: 0.6.3
Status: install ok installed
Priority: optional
Maintainer: James McMurray <[email protected]>
Installed-Size: 8,183 kB
Homepage: https://github.com/jamesmcm/vopono
Vcs-Browser: https://github.com/jamesmcm/vopono
Vcs-Git: https://github.com/jamesmcm/vopono
Standards-Version: 3.9.4
Download-Size: unknown
APT-Manual-Installed: yes
APT-Sources: /var/lib/dpkg/status
Description: Launch applications via VPN tunnels using temporary network namespaces

Here's what I get when running vopono exec ....

 2020-12-20T17:57:47.382Z ERROR vopono::wireguard > wg binary not found. Is wireguard-tools installed and on PATH?
Error: wg binary not found. Is wireguard-tools installed and on PATH?: CannotFindBinaryPath

One could argue that the dependency on wireguard-tools should be optional as the vopono sync operation is useful in itself.

@jamesmcm
Copy link
Owner Author

Yeah, it's only done on the AUR.

I'll add the dependencies to the cargo-deb file: https://github.com/mmstick/cargo-deb

@jamesmcm jamesmcm reopened this Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants