Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading pre-extracted feature bags for slide prediction using MIL model in slideflow studio #349

Open
sz3029 opened this issue Jan 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sz3029
Copy link

sz3029 commented Jan 23, 2024

Feature

Currently the MIL extension in slideflow studio redo tile extraction and feature extraction each time for slide predictions, which would take a long time. For robustness, is it possible if we can have an option to load the pre-extracted feature bags of the slides (the tile-extraction parameter is fixed in this case)?

Pitch

When we use the Predict Slide feature, we can have an option to load the paths of the feature bags, like in P.train_mil().
In the _mil_renderer.py file, instead of using _convert_img_to_bag we can directly load the bag (probably using dataset.pt_files(bag)) for the dataset we loaded with the project. Then the bags can be passed to the _predict_bag function when we're making prediction for individual slides.

@sz3029 sz3029 added the enhancement New feature or request label Jan 23, 2024
@jamesdolezal
Copy link
Owner

This is a great idea! We'll need to put some time into thinking about how to integrate this option into a UI in a way that would be intuitive. But I definitely think it's possible and would be a good enhancement. Will update this issue when we draft together a strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants