Fix#45 #48
Closed
Fix#45 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops. Mea culpa. |
RGD2
force-pushed
the
fix#45
branch
3 times, most recently
from
35bb1b1
to
c2c480a
Compare
|
Hmm... hold off on this for a bit - gotten home to find what was working in the lab, isn't working here with a different build environment and board... |
Moved async_in_filter.v because it was annoying verilator, and it belongs in its new home, as it references ice specific hardware anyway.
|
Ok, 241015a should be good. I just now tested j1a, j1a8k and j4a, and all were happy at 921600. |
|
I think I can do a simpler version of this patch, without uart3.v, just with async_in_filter.v |
|
It does appear to work... Probably best to go with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #45, and may help with #15 and #39, possibly fixing those too.
It's a reimplementation of the 'buart' receiver, which is tested up to 921600, and theoretically should work up to about 2Mbaud.