Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass size and props for the icons #10

Closed
Bug-Finderr opened this issue Nov 7, 2024 · 2 comments
Closed

Pass size and props for the icons #10

Bug-Finderr opened this issue Nov 7, 2024 · 2 comments

Comments

@Bug-Finderr
Copy link

I was using the expandIcon variant in my project and noticed something.

image

On hover, the SearchIcon (lucide-react) was not the right size.

And I could not find a way to pass it via component calling

image

Hence updating few parts in the components/ui/button.tsx solved the problem.
Raised this issue so that no one else has to face this.

@Bug-Finderr
Copy link
Author

If this was a dumb issue and could've been solved some other already defined way please do share the idea. Else, please assign me this issue, I'll be able to solve it

@Bug-Finderr
Copy link
Author

Oh, such a PR is pending to be merged. Hope it gets merged soon~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant