Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoveEntries not working #56

Open
thomas694 opened this issue Jan 20, 2025 · 2 comments · May be fixed by #60
Open

RemoveEntries not working #56

thomas694 opened this issue Jan 20, 2025 · 2 comments · May be fixed by #60

Comments

@thomas694
Copy link
Contributor

thomas694 commented Jan 20, 2025 •
edited
Loading

Currently, the passed entries are not removed by RemoveEntries.
I wonder how this even worked, at least in the current implementation.
As in Line 564 ReadCentralDir creates new objects each time it is called, how can they be identical to any object in the parameter list?

The new version could treat two objects as equal if they have the same header offset values and thus point to the same archive entry.
@thomas694 thomas694 linked a pull request Jan 20, 2025 that will close this issue
Open
@jaime-olivares
Copy link
Owner

Hi @thomas694 I was reviewing this week all your PR, but I cannot keep moving until you test the merged PR for zip64, already in nuget as a beta

@thomas694
Copy link
Contributor Author

Hi, sure, that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue RemoveEntries not working thomas694/zipstorer
2 participants
@jaime-olivares @thomas694