Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate namespaces #9

Open
jagot opened this issue Apr 12, 2024 · 1 comment
Open

Separate namespaces #9

jagot opened this issue Apr 12, 2024 · 1 comment

Comments

@jagot
Copy link
Owner

jagot commented Apr 12, 2024

We need to ensure all modules have distinct names, since multiple modules with the same name is undefined behaviour according to the Fortran standard, and leads to confusion in general. My suggestion is to prefix all modules which belong to a specific program by the name of the program, e.g. av_energy_expression -> dbsr_mchf_av_energy_expression, &c. Similarly, there is significant overlap between versions 3 and 4, and here I suggest we suffix all modules by the version number.

@jagot
Copy link
Owner Author

jagot commented Apr 12, 2024

Another big advantage to this, is that we can then properly support efficient, parallel builds using Ninja, which requires that all Fortran modules have distinct names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant