Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafka] OTEL helper instead of tlscfg package #6270

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (4a14e87) to head (f995ab7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6270       +/-   ##
===========================================
+ Coverage   48.78%   96.44%   +47.65%     
===========================================
  Files         179      355      +176     
  Lines       10799    20152     +9353     
===========================================
+ Hits         5268    19435    +14167     
+ Misses       5088      528     -4560     
+ Partials      443      189      -254     
Flag Coverage Δ
badger_v1 8.31% <0.00%> (+<0.01%) ⬆️
badger_v2 1.67% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 14.39% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2 1.61% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v1 14.39% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v2 1.61% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x-v1 18.60% <0.00%> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.69% <0.00%> (+0.01%) ⬆️
elasticsearch-8.x-v1 18.86% <0.00%> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.67% <0.00%> (+0.01%) ⬆️
grpc_v1 9.45% <0.00%> (+<0.01%) ⬆️
grpc_v2 6.99% <0.00%> (+<0.01%) ⬆️
kafka-v1 8.87% <12.50%> (-0.01%) ⬇️
kafka-v2 1.67% <0.00%> (+<0.01%) ⬆️
memory_v2 1.67% <0.00%> (+0.01%) ⬆️
opensearch-1.x-v1 18.74% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v1 18.73% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v2 1.66% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.46% <0.00%> (+<0.01%) ⬆️
unittests 95.35% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: chahatsagarmain <[email protected]>
@yurishkuro yurishkuro merged commit 1a09227 into jaegertracing:main Nov 28, 2024
52 of 53 checks passed
@chahatsagarmain chahatsagarmain deleted the kafka-tls branch November 28, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants