Move Decorator From Query Extension To Storage Extension

Signed-off-by: Mahad Zaryab <[email protected]>
jaegertracing · Nov 29, 2024 · d669fac · d669fac
1 parent fb0ecae
commit d669fac
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/cmd/jaeger/internal/extension/jaegerquery/server.go b/cmd/jaeger/internal/extension/jaegerquery/server.go
@@ -24,7 +24,6 @@ import (
 	"github.com/jaegertracing/jaeger/plugin/metrics/disabled"
 	"github.com/jaegertracing/jaeger/storage/metricsstore"
 	"github.com/jaegertracing/jaeger/storage/metricsstore/metricstoremetrics"
-	"github.com/jaegertracing/jaeger/storage/storagemetrics"
 )
 
 var (
@@ -60,7 +59,6 @@ func (s *server) Start(ctx context.Context, host component.Host) error {
 	if err != nil {
 		return fmt.Errorf("cannot find primary storage %s: %w", s.config.Storage.TracesPrimary, err)
 	}
-	f = storagemetrics.NewDecoratorFactory(f, baseFactory)
 
 	spanReader, err := f.CreateSpanReader()
 	if err != nil {

diff --git a/cmd/jaeger/internal/extension/jaegerstorage/extension.go b/cmd/jaeger/internal/extension/jaegerstorage/extension.go
@@ -24,6 +24,7 @@ import (
 	"github.com/jaegertracing/jaeger/plugin/storage/grpc"
 	"github.com/jaegertracing/jaeger/plugin/storage/memory"
 	"github.com/jaegertracing/jaeger/storage"
+	"github.com/jaegertracing/jaeger/storage/storagemetrics"
 	"github.com/jaegertracing/jaeger/storage_v2/factoryadapter"
 	"github.com/jaegertracing/jaeger/storage_v2/spanstore"
 )
@@ -150,7 +151,15 @@ func (s *storageExt) Start(_ context.Context, host component.Host) error {
 		if err != nil {
 			return fmt.Errorf("failed to initialize storage '%s': %w", storageName, err)
 		}
-		s.factories[storageName] = factory
+		storageMetricsFactory := mf.Namespace(
+			metrics.NSOptions{
+				Name: "storage",
+				Tags: map[string]string{
+					"kind": storageName,
+				},
+			},
+		)
+		s.factories[storageName] = storagemetrics.NewDecoratorFactory(factory, storageMetricsFactory)
 	}
 
 	for metricStorageName, cfg := range s.config.MetricBackends {