Address Feedback For Error Variable

Signed-off-by: Mahad Zaryab <[email protected]>
jaegertracing · Nov 19, 2024 · 1683007 · 1683007
1 parent 1175e6e
commit 1683007
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/storage_v2/factoryadapter/reader.go b/storage_v2/factoryadapter/reader.go
@@ -14,7 +14,7 @@ import (
 	"github.com/jaegertracing/jaeger/storage_v2/spanstore"
 )
 
-var ErrV1ReaderNotAvailable = errors.New("v1 reader is not available")
+var errV1ReaderNotAvailable = errors.New("spanstore.Reader is not a wrapper around v1 reader")
 
 type TraceReader struct {
 	spanReader spanstore_v1.Reader
@@ -24,7 +24,7 @@ func GetV1Reader(reader spanstore.Reader) (spanstore_v1.Reader, error) {
 	if tr, ok := reader.(*TraceReader); ok {
 		return tr.spanReader, nil
 	}
-	return nil, ErrV1ReaderNotAvailable
+	return nil, errV1ReaderNotAvailable
 }
 
 func NewTraceReader(spanReader spanstore_v1.Reader) *TraceReader {

diff --git a/storage_v2/factoryadapter/reader_test.go b/storage_v2/factoryadapter/reader_test.go
@@ -50,7 +50,7 @@ func (*fakeReader) FindTraceIDs(_ context.Context, _ spanstore.TraceQueryParamet
 func TestGetV1Reader_Error(t *testing.T) {
 	fr := &fakeReader{}
 	_, err := GetV1Reader(fr)
-	require.ErrorIs(t, err, ErrV1ReaderNotAvailable)
+	require.ErrorIs(t, err, errV1ReaderNotAvailable)
 }
 
 func TestTraceReader_GetTracePanics(t *testing.T) {