From 8f5814a5bbd68acc3812ac85160f710eef57e15a Mon Sep 17 00:00:00 2001 From: Aditya <110272990+ADI-ROXX@users.noreply.github.com> Date: Sun, 26 Jan 2025 05:20:20 +0530 Subject: [PATCH] Remove defaultProps from TraceHeader.jsx (#2620) ## Which problem is this PR solving? - Part of #2596 ## Description of the changes - ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: cs-308-2023 --- .../TraceDiff/TraceDiffHeader/TraceHeader.tsx | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceHeader.tsx b/packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceHeader.tsx index 5baba664bb..eb437b2b54 100644 --- a/packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceHeader.tsx +++ b/packages/jaeger-ui/src/components/TraceDiff/TraceDiffHeader/TraceHeader.tsx @@ -75,8 +75,15 @@ export function Attrs(props: AttrsProps) { ); } -export default function TraceHeader(props: Props) { - const { duration, error, startTime, state, traceID, totalSpans, traceName } = props; +export default function TraceHeader({ + duration, + error, + startTime, + state, + traceID, + totalSpans, + traceName, +}: Props) { const AttrsComponent = state === fetchedState.DONE ? Attrs : EmptyAttrs; return ( @@ -101,7 +108,3 @@ export default function TraceHeader(props: Props) { ); } - -TraceHeader.defaultProps = { - error: undefined, -};